Bug 69374 - Update html5-full-render.html to load the HTML5 spec incrementally, closer to how the browser would
Summary: Update html5-full-render.html to load the HTML5 spec incrementally, closer to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 68944
  Show dependency tree / graph
 
Reported: 2011-10-04 14:03 PDT by Eric Seidel (no email)
Modified: 2011-10-06 13:43 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.47 KB, patch)
2011-10-04 14:04 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-10-04 14:03:42 PDT 
Update html5-full-render.html to load the HTML5 spec incrementally, closer to how the browser would
Comment 1 Eric Seidel (no email) 2011-10-04 14:04:57 PDT 
Created attachment 109683 [details]
Patch
Comment 2 James Robinson 2011-10-04 14:11:44 PDT 
Comment on attachment 109683 [details]
Patch

Seems reasonable.
Comment 3 Eric Seidel (no email) 2011-10-04 14:17:09 PDT 
Thanks.
Comment 4 WebKit Review Bot 2011-10-04 14:26:10 PDT 
Comment on attachment 109683 [details]
Patch

Clearing flags on attachment: 109683

Committed r96647: <http://trac.webkit.org/changeset/96647>
Comment 5 WebKit Review Bot 2011-10-04 14:26:15 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Eric Seidel (no email) 2011-10-04 14:31:41 PDT 
@antti and others who may want to use this benchmark:

Once we sort out the the style selection issue, we may wish to tweak the chunksize down a bit to more closely match normal in-browser loads.  I expect we do more than 12 style resolves in a normal in-browser load.
Comment 7 Eric Seidel (no email) 2011-10-04 14:37:36 PDT 
Hmm.  I now realize that I updated the html5.html file before posting this to remove the absolute URLs that Chrome's "save as page" had added.  That reduced the size from 8mb to 6mb and thus brought our number of forced style resolves from 12 down to 9.  I'll tweak the chunkSize to bring that number back up, as otherwise style resolution won't show up very hot.
Comment 8 Eric Seidel (no email) 2011-10-04 15:55:44 PDT 
Committed r96658: <http://trac.webkit.org/changeset/96658>