Bug 69372 - [CSS3 Regions] Make sure overflow:visible lets content spill out of regions.
Summary: [CSS3 Regions] Make sure overflow:visible lets content spill out of regions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 57312
  Show dependency treegraph
 
Reported: 2011-10-04 13:49 PDT by Dave Hyatt
Modified: 2012-07-23 23:17 PDT (History)
3 users (show)

See Also:


Attachments
Patch (579.35 KB, patch)
2011-10-04 13:53 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch (579.65 KB, patch)
2011-10-04 13:56 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch (590.59 KB, patch)
2011-10-04 14:05 PDT, Dave Hyatt
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2011-10-04 13:49:16 PDT
Make sure overflow:visible lets content spill out of regions. Also make sure regions do not clip their content in the flow thread's inline direction.
Comment 1 Dave Hyatt 2011-10-04 13:53:01 PDT
Created attachment 109677 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-04 13:55:51 PDT
Attachment 109677 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Source/WebCore/rendering/RenderRegion.cpp:129:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2011-10-04 13:56:40 PDT
Created attachment 109680 [details]
Patch
Comment 4 WebKit Review Bot 2011-10-04 13:58:53 PDT
Attachment 109680 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Dave Hyatt 2011-10-04 14:05:46 PDT
Created attachment 109684 [details]
Patch
Comment 6 WebKit Review Bot 2011-10-04 14:10:59 PDT
Attachment 109684 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Source/JavaScriptCore/wtf/ListHashSet.h:410:  const_reverse_iterator is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/wtf/ListHashSet.h:451:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Csaba Osztrogonác 2011-10-05 00:03:37 PDT
Patch landed http://trac.webkit.org/changeset/96643, but unfortunately WebKit2 doesn't build on Qt, because of -Werror:

cc1plus: warnings being treated as errors
In file included from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebCore/rendering/HitTestResult.h:27,
                 from ../include/WebCore/HitTestResult.h:1,
                 from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/Shared/WebHitTestResult.h:24,
                 from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/UIProcess/WebPageProxy.h:49,
                 from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/UIProcess/WebBackForwardList.h:32,
                 from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/Shared/SessionState.h:29,
                 from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/Shared/WebPageCreationParameters.h:30,
                 from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/Shared/WebPageCreationParameters.cpp:27:
/ramdisk/qt-linux-32-release-webkit2/build/Source/JavaScriptCore/wtf/ListHashSet.h:429: error: class ‘WTF::ListHashSetConstReverseIterator<ValueArg, inlineCapacity, HashArg>’ is implicitly friends with itself
Comment 8 Csaba Osztrogonác 2011-10-06 05:45:06 PDT
Patch landed in http://trac.webkit.org/changeset/96643 and buildfix laned in http://trac.webkit.org/changeset/96648.