Bug 69356 - Move font-fixup code in WebKitTestRunner to a better place
Summary: Move font-fixup code in WebKitTestRunner to a better place
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-04 11:25 PDT by Simon Fraser (smfr)
Modified: 2011-10-04 11:39 PDT (History)
2 users (show)

See Also:


Attachments
Patch (14.55 KB, patch)
2011-10-04 11:26 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (13.45 KB, patch)
2011-10-04 11:29 PDT, Simon Fraser (smfr)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-10-04 11:25:27 PDT
Move font-fixup code in WebKitTestRunner to a better place
Comment 1 Simon Fraser (smfr) 2011-10-04 11:26:24 PDT
Created attachment 109656 [details]
Patch
Comment 2 Sam Weinig 2011-10-04 11:28:47 PDT
Comment on attachment 109656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109656&action=review

> Tools/WebKitTestRunner/InjectedBundle/ActivateFonts.h:31
>  
> -void activateFonts();
> +void adjustFonts();

This should stay named activateFonts, because otherwise you will break everyone else.
Comment 3 Simon Fraser (smfr) 2011-10-04 11:29:48 PDT
Created attachment 109657 [details]
Patch
Comment 4 Simon Fraser (smfr) 2011-10-04 11:39:53 PDT
http://trac.webkit.org/changeset/96623