Bug 69349 - garden-o-matic doesn't launch its UI on Lion
Summary: garden-o-matic doesn't launch its UI on Lion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-04 10:36 PDT by Adam Barth
Modified: 2011-10-05 12:25 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.52 KB, patch)
2011-10-04 10:38 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-10-04 10:36:22 PDT
garden-o-matic doesn't launch it's UI on Lion
Comment 1 Adam Barth 2011-10-04 10:38:07 PDT
Created attachment 109643 [details]
Patch
Comment 2 Darin Adler 2011-10-04 10:46:39 PDT
Comment on attachment 109643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109643&action=review

> Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:92
> +        return 'file://' + os.path.join(GardeningHTTPRequestHandler.STATIC_FILE_DIRECTORY, 'garden-o-matic.html')

Strictly speaking, prepending "file://" does not make a file URL. It would be better if there was a function that did the necessary escaping as well.
Comment 3 Adam Barth 2011-10-04 10:47:51 PDT
> Strictly speaking, prepending "file://" does not make a file URL. It would be better if there was a function that did the necessary escaping as well.

Very true.  I looked for one in the Python standard library, but I couldn't find one.  I suppose I could write one.
Comment 4 WebKit Review Bot 2011-10-04 12:23:15 PDT
Comment on attachment 109643 [details]
Patch

Attachment 109643 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9954132

New failing tests:
inspector/debugger/debugger-activation-crash2.html
Comment 5 Adam Barth 2011-10-04 17:51:14 PDT
Comment on attachment 109643 [details]
Patch

Clearing flags on attachment: 109643

Committed r96666: <http://trac.webkit.org/changeset/96666>