RESOLVED FIXED Bug 69349
garden-o-matic doesn't launch its UI on Lion 
https://bugs.webkit.org/show_bug.cgi?id=69349
Summary garden-o-matic doesn't launch its UI on Lion
Adam Barth
Reported 2011-10-04 10:36:22 PDT
garden-o-matic doesn't launch it's UI on Lion
Attachments
Patch (1.52 KB, patch)
2011-10-04 10:38 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-10-04 10:38:07 PDT
Created attachment 109643 [details] Patch
Darin Adler
Comment 2 2011-10-04 10:46:39 PDT
Comment on attachment 109643 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109643&action=review > Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:92 > + return 'file://' + os.path.join(GardeningHTTPRequestHandler.STATIC_FILE_DIRECTORY, 'garden-o-matic.html') Strictly speaking, prepending "file://" does not make a file URL. It would be better if there was a function that did the necessary escaping as well.
Adam Barth
Comment 3 2011-10-04 10:47:51 PDT
> Strictly speaking, prepending "file://" does not make a file URL. It would be better if there was a function that did the necessary escaping as well. Very true. I looked for one in the Python standard library, but I couldn't find one. I suppose I could write one.
WebKit Review Bot
Comment 4 2011-10-04 12:23:15 PDT
Comment on attachment 109643 [details] Patch Attachment 109643 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9954132 New failing tests: inspector/debugger/debugger-activation-crash2.html
Adam Barth
Comment 5 2011-10-04 17:51:14 PDT
Comment on attachment 109643 [details] Patch Clearing flags on attachment: 109643 Committed r96666: <http://trac.webkit.org/changeset/96666>
Note You need to log in before you can comment on or make changes to this bug.