Bug 69344 - WKPreferences should allow control of application chrome mode
Summary: WKPreferences should allow control of application chrome mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jeff Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-04 10:02 PDT by Jeff Miller
Modified: 2011-10-04 11:14 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.78 KB, patch)
2011-10-04 10:39 PDT, Jeff Miller
no flags Details | Formatted Diff | Diff
Patch (3.83 KB, patch)
2011-10-04 11:06 PDT, Jeff Miller
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Miller 2011-10-04 10:02:50 PDT
WebKit2 needs the equivalent of WebPreferences' setApplicationChromeModeEnabled() in WebKit1.
Comment 1 Jeff Miller 2011-10-04 10:39:29 PDT
Created attachment 109644 [details]
Patch
Comment 2 mitz 2011-10-04 10:41:26 PDT
Comment on attachment 109644 [details]
Patch

I think this should be declared in WKPreferencesPrivate.h (the WebKit1 equivalent is in WebPreferencesPrivate.h).
Comment 3 Jeff Miller 2011-10-04 10:57:05 PDT
(In reply to comment #2)
> (From update of attachment 109644 [details])
> I think this should be declared in WKPreferencesPrivate.h (the WebKit1 equivalent is in WebPreferencesPrivate.h).

Whoops, I missed that, you're right.
Comment 4 Jeff Miller 2011-10-04 11:06:41 PDT
Created attachment 109652 [details]
Patch
Comment 5 Jeff Miller 2011-10-04 11:14:38 PDT
Committed r96619: <http://trac.webkit.org/changeset/96619>