Bug 69342 - force gray-aa if we must disable LCD due to drawing in a layer
Summary: force gray-aa if we must disable LCD due to drawing in a layer
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Reed
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-04 08:53 PDT by Mike Reed
Modified: 2012-02-22 09:53 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2011-10-04 08:54 PDT, Mike Reed 		no flags Details | Formatted Diff | Diff
Patch (1.99 KB, patch)
2011-10-04 12:05 PDT, Mike Reed 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reed 2011-10-04 08:53:13 PDT 
force gray-aa if we must disable LCD due to drawing in a layer
Comment 1 Mike Reed 2011-10-04 08:54:50 PDT 
Created attachment 109627 [details]
Patch
Comment 2 James Robinson 2011-10-04 11:37:27 PDT 
Comment on attachment 109627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109627&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. existing tests apply

This is just a lie - we don't have any layout tests that detect this change in behavior (which is why it's been broken so often over the past few weeks). Ideally we'd have tests - but if you can't come up with a way to add them, at least be honest in the ChangeLog.

I really think we do need an automated way to test this - be it layout tests or browser tests or something else.  The current situation is we break it all the time and don't know until users complain.
Comment 3 Mike Reed 2011-10-04 12:05:29 PDT 
Created attachment 109662 [details]
Patch
Comment 4 Eric Seidel (no email) 2012-02-16 14:39:32 PST 
James?  (5-month ping)  :)
Comment 5 James Robinson 2012-02-16 14:40:52 PST 
There have been a lot of changes in this area, I'm not sure if this patch still applies.  Mike?
Comment 6 Mike Reed 2012-02-22 04:21:08 PST 
this patch is obsolete
Comment 7 Mike Reed 2012-02-22 09:53:19 PST 
Thanks Stephen, I didn't know the convention (resolved + invalid) for deprecating an issue.