WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
69340
Web Inspector: saving JavaScript after live edit resets scroller position.
https://bugs.webkit.org/show_bug.cgi?id=69340
Summary
Web Inspector: saving JavaScript after live edit resets scroller position.
Pavel Feldman
Reported
2011-10-04 08:24:11 PDT
1. Start editing 2. Hit Ctrl+Save (Cmd+Save) scrol top is set to 0
Attachments
Patch
(11.73 KB, patch)
2011-10-06 10:14 PDT
,
Pavel Podivilov
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Podivilov
Comment 1
2011-10-06 10:14:04 PDT
Created
attachment 109971
[details]
Patch
Yury Semikhatsky
Comment 2
2011-10-07 02:00:03 PDT
Comment on
attachment 109971
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=109971&action=review
> Source/WebCore/inspector/front-end/UISourceCode.js:81 > + contentChanged: function()
Looking at the current implementation, it seems that we can pass new content as a parameter here and avoid additional requestContent later.
> Source/WebCore/inspector/front-end/UISourceCode.js:84 > + this._contentLoaded = false;
this._content should also be cleared
Pavel Podivilov
Comment 3
2011-10-10 05:39:53 PDT
Committed
r97056
: <
http://trac.webkit.org/changeset/97056
>
Csaba Osztrogonác
Comment 4
2011-10-10 06:24:12 PDT
It broke inspector/debugger/script-formatter.html. On the SL bot:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r97056%20%2833778%29/inspector/debugger/script-formatter-pretty-diff.html
On the Qt bot:
http://build.webkit.org/results/Qt%20Linux%20Release/r97056%20%2838357%29/inspector/debugger/script-formatter-pretty-diff.html
Reopen to fix it.
Csaba Osztrogonác
Comment 5
2011-10-10 06:24:27 PDT
Comment on
attachment 109971
[details]
Patch remove r+ from landed patcg
Csaba Osztrogonác
Comment 6
2011-10-10 08:08:05 PDT
Fix landed in
http://trac.webkit.org/changeset/97060
Pavel Feldman
Comment 7
2011-10-11 07:54:33 PDT
***
Bug 69842
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug