Bug 69340 - Web Inspector: saving JavaScript after live edit resets scroller position.
Summary: Web Inspector: saving JavaScript after live edit resets scroller position.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
: 69842 (view as bug list)
Depends on:
Reported: 2011-10-04 08:24 PDT by Pavel Feldman
Modified: 2011-10-11 07:54 PDT (History)
13 users (show)

See Also:

Patch (11.73 KB, patch)
2011-10-06 10:14 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-10-04 08:24:11 PDT
1. Start editing
2. Hit Ctrl+Save (Cmd+Save)

scrol top is set to 0
Comment 1 Pavel Podivilov 2011-10-06 10:14:04 PDT
Created attachment 109971 [details]
Comment 2 Yury Semikhatsky 2011-10-07 02:00:03 PDT
Comment on attachment 109971 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=109971&action=review

> Source/WebCore/inspector/front-end/UISourceCode.js:81
> +    contentChanged: function()

Looking at the current implementation, it seems that we can pass new content as a parameter here and avoid additional requestContent later.

> Source/WebCore/inspector/front-end/UISourceCode.js:84
> +        this._contentLoaded = false;

this._content should also be cleared
Comment 3 Pavel Podivilov 2011-10-10 05:39:53 PDT
Committed r97056: <http://trac.webkit.org/changeset/97056>
Comment 5 Csaba Osztrogonác 2011-10-10 06:24:27 PDT
Comment on attachment 109971 [details]

remove r+ from landed patcg
Comment 6 Csaba Osztrogonác 2011-10-10 08:08:05 PDT
Fix landed in http://trac.webkit.org/changeset/97060
Comment 7 Pavel Feldman 2011-10-11 07:54:33 PDT
*** Bug 69842 has been marked as a duplicate of this bug. ***