Bug 69338 - Fails to build when sqlite is not in /usr/include
Summary: Fails to build when sqlite is not in /usr/include
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-04 08:00 PDT by Rémi Duraffort
Modified: 2011-10-04 11:03 PDT (History)
6 users (show)

See Also:

Attachments
Fix compilation flags typos (1.93 KB, patch)
2011-10-04 08:00 PDT, Rémi Duraffort 		leandro: review-
Details | Formatted Diff | Diff
Fix compilation flags typos (1.99 KB, patch)
2011-10-04 08:18 PDT, Rémi Duraffort 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rémi Duraffort 2011-10-04 08:00:51 PDT 
Created attachment 109622 [details]
Fix  compilation flags typos

WebKit/EFL fails to build when SQLite3 is no installed in /usr/include.

Source/WebCore/platform/sql/SQLiteAuthorizer.cpp:32:21: error: sqlite3.h: No such file or directory
Source/WebCore/platform/sql/SQLiteAuthorizer.cpp:36: error: 'SQLITE_OK' was not declared in this scope
Source/WebCore/platform/sql/SQLiteAuthorizer.cpp:37: error: 'SQLITE_IGNORE' was not declared in this scope
Source/WebCore/platform/sql/SQLiteAuthorizer.cpp:38: error: 'SQLITE_DENY' was not declared in this scope
Comment 1 WebKit Review Bot 2011-10-04 08:03:21 PDT 
Attachment 109622 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeListsEfl.txt', u'Sourc..." exit_code: 1

Source/WebKit/efl/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Leandro Pereira 2011-10-04 08:09:45 PDT 
Comment on attachment 109622 [details]
Fix  compilation flags typos

View in context: https://bugs.webkit.org/attachment.cgi?id=109622&action=review

Informal r-.

> Source/WebCore/CMakeListsEfl.txt:243
> -  ${ICU_INCLUDE_DIRS}
> +  ${ICU_INCLUDE_DIR}

FindICU actually sets ICU_INCLUDE_DIRS.

> Source/WebCore/CMakeListsEfl.txt:246
> -  ${LIBXSLT_INCLUDE_DIRS}
> -  ${SQLITE_INCLUDE_DIRS}
> +  ${LIBXSLT_INCLUDE_DIR}
> +  ${SQLITE_INCLUDE_DIR}

This looks fine; however, please mention xslt as well in the ChangeLog entry.

> Source/WebCore/ChangeLog:1
> +2011-10-04  Rémi Duraffort  <remi.duraffort@st.com>

I'll assume this encoding error is Bugzilla's fault.
Comment 3 Leandro Pereira 2011-10-04 08:12:08 PDT 
(In reply to comment #1)
> Source/WebKit/efl/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
> Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]

Please add the URL to this bug as well to make the bots happy.

(Also, since this is a build fix, it does not require formal review; you can say 'Unreviewed build fix', and I'll be able to commit it as soon as these small issues are ironed out.)
Comment 4 Rémi Duraffort 2011-10-04 08:18:12 PDT 
Created attachment 109623 [details]
Fix compilation flags typos

Second patch, taking reviews into account.
Comment 5 Leandro Pereira 2011-10-04 09:39:09 PDT 
Comment on attachment 109623 [details]
Fix compilation flags typos

Thanks.
Comment 6 WebKit Review Bot 2011-10-04 11:03:26 PDT 
Comment on attachment 109623 [details]
Fix compilation flags typos

Clearing flags on attachment: 109623

Committed r96612: <http://trac.webkit.org/changeset/96612>
Comment 7 WebKit Review Bot 2011-10-04 11:03:31 PDT 
All reviewed patches have been landed.  Closing bug.