Created attachment 109622 [details] Fix compilation flags typos WebKit/EFL fails to build when SQLite3 is no installed in /usr/include. Source/WebCore/platform/sql/SQLiteAuthorizer.cpp:32:21: error: sqlite3.h: No such file or directory Source/WebCore/platform/sql/SQLiteAuthorizer.cpp:36: error: 'SQLITE_OK' was not declared in this scope Source/WebCore/platform/sql/SQLiteAuthorizer.cpp:37: error: 'SQLITE_IGNORE' was not declared in this scope Source/WebCore/platform/sql/SQLiteAuthorizer.cpp:38: error: 'SQLITE_DENY' was not declared in this scope
Attachment 109622 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeListsEfl.txt', u'Sourc..." exit_code: 1 Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 109622 [details] Fix compilation flags typos View in context: https://bugs.webkit.org/attachment.cgi?id=109622&action=review Informal r-. > Source/WebCore/CMakeListsEfl.txt:243 > - ${ICU_INCLUDE_DIRS} > + ${ICU_INCLUDE_DIR} FindICU actually sets ICU_INCLUDE_DIRS. > Source/WebCore/CMakeListsEfl.txt:246 > - ${LIBXSLT_INCLUDE_DIRS} > - ${SQLITE_INCLUDE_DIRS} > + ${LIBXSLT_INCLUDE_DIR} > + ${SQLITE_INCLUDE_DIR} This looks fine; however, please mention xslt as well in the ChangeLog entry. > Source/WebCore/ChangeLog:1 > +2011-10-04 Rémi Duraffort <remi.duraffort@st.com> I'll assume this encoding error is Bugzilla's fault.
(In reply to comment #1) > Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Please add the URL to this bug as well to make the bots happy. (Also, since this is a build fix, it does not require formal review; you can say 'Unreviewed build fix', and I'll be able to commit it as soon as these small issues are ironed out.)
Created attachment 109623 [details] Fix compilation flags typos Second patch, taking reviews into account.
Comment on attachment 109623 [details] Fix compilation flags typos Thanks.
Comment on attachment 109623 [details] Fix compilation flags typos Clearing flags on attachment: 109623 Committed r96612: <http://trac.webkit.org/changeset/96612>
All reviewed patches have been landed. Closing bug.