Bug 69327 - Web Inspector: remove dependency from GoToLine dialog from Panel.
Summary: Web Inspector: remove dependency from GoToLine dialog from Panel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-04 01:53 PDT by Pavel Feldman
Modified: 2011-10-04 02:16 PDT (History)
11 users (show)

See Also:


Attachments
Patch (9.94 KB, patch)
2011-10-04 02:09 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-10-04 01:53:52 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-10-04 02:09:23 PDT
Created attachment 109597 [details]
Patch
Comment 2 Yury Semikhatsky 2011-10-04 02:14:16 PDT
Comment on attachment 109597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109597&action=review

> Source/WebCore/inspector/front-end/GoToLineDialog.js:84
> +    if (!sourceView || !sourceView.canHighlightLine())

!sourceView check is redundant, please remove.
Comment 3 Pavel Feldman 2011-10-04 02:16:18 PDT
Committed r96577: <http://trac.webkit.org/changeset/96577>