Bug 69323 - watchlist: Add more rules for chromium public api and sort the file.
Summary: watchlist: Add more rules for chromium public api and sort the file.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on: 69303
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-04 00:08 PDT by David Levin
Modified: 2011-10-05 02:28 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.70 KB, patch)
2011-10-04 00:10 PDT, David Levin 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-10-04 00:08:23 PDT 
See summary.
Comment 1 David Levin 2011-10-04 00:09:38 PDT 
It would be best if bug 69303 were fixed before this change is checked in.
Comment 2 David Levin 2011-10-04 00:10:36 PDT 
Created attachment 109586 [details]
Patch
Comment 3 Adam Barth 2011-10-04 10:51:24 PDT 
Comment on attachment 109586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109586&action=review

> Tools/Scripts/webkitpy/common/config/watchlist:31
> +        "ChromiumPublicApi": [ "Please wait for approval from darin@chromium.org before submitting "

darin@chromium.org => fishd@chromium.org

> Tools/Scripts/webkitpy/common/config/watchlist:32
> +                               "because this patch contains changes to the Chromium public api.", ],

api => API.
Comment 4 David Levin 2011-10-05 02:28:48 PDT 
Addressed comments and committed as http://trac.webkit.org/changeset/96688