RESOLVED FIXED 69317
[CSS3 Regions] Make overflow:hidden/auto/scroll objects work in regions 
https://bugs.webkit.org/show_bug.cgi?id=69317
Summary [CSS3 Regions] Make overflow:hidden/auto/scroll objects work in regions
Dave Hyatt
Reported 2011-10-03 22:26:37 PDT
Make overflow:hidden/auto/scroll objects work in regions. They need to be able to size and position independently in each region, including shifting to avoid floats, sizing around floats, clipping differently, and so on.
Attachments
Patch (712.99 KB, patch)
2011-10-03 22:50 PDT, Dave Hyatt 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (849.33 KB, patch)
2011-10-04 09:27 PDT, Dave Hyatt 		andersca: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2011-10-03 22:50:08 PDT
Created attachment 109581 [details] Patch
WebKit Review Bot
Comment 2 2011-10-04 05:23:03 PDT
Comment on attachment 109581 [details] Patch Attachment 109581 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9936515 New failing tests: http/tests/security/xssAuditor/cookie-injection.html fast/multicol/image-inside-nested-blocks-with-border.html fast/multicol/float-paginate.html fast/multicol/client-rects.html fast/multicol/span/span-as-immediate-columns-child-dynamic.html fast/multicol/span/span-as-immediate-child-generated-content.html fast/multicol/column-rules.html fast/multicol/column-count-with-rules.html fast/multicol/float-paginate-complex.html fast/multicol/span/span-as-immediate-child-complex-splitting.html fast/multicol/border-padding-pagination.html fast/multicol/column-break-with-balancing.html fast/multicol/span/anonymous-split-block-crash.html fast/multicol/span/span-as-immediate-child-property-removal.html fast/forms/input-spinbutton-capturing.html fast/forms/input-number-large-padding.html fast/events/offsetX-offsetY.html fast/forms/input-number-events.html fast/multicol/span/anonymous-before-child-parent-crash.html fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html
Dave Hyatt
Comment 3 2011-10-04 09:27:23 PDT
Created attachment 109632 [details] Patch Changes from the previous patch: (1) Added updated results for two multicol tests that progressed, since they relied on the buggy getClearDelta behavior before. Now that getClearDelta is patched for writing modes, the overflow sections properly shifted below the floats. (2) Fixed failing tests caused by offsetFromLogicalTopOfFirstPage() bailing if you weren't in a render flow thread. Changed it to be like it used to be, and bail when you're not paginated.
Anders Carlsson
Comment 4 2011-10-04 09:45:29 PDT
Comment on attachment 109632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109632&action=review > Source/WebCore/rendering/RenderBlock.cpp:1815 > + // FIXME: Needs to use epsilon once we switch to float, see https://bugs.webkit.org/show_bug.cgi?id=64021 Indentation is off here. > Source/WebCore/rendering/RenderBlock.h:432 > + Extra whitespace.
WebKit Review Bot
Comment 5 2011-10-04 10:18:12 PDT
Comment on attachment 109632 [details] Patch Attachment 109632 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9936580 New failing tests: fast/multicol/vertical-rl/float-avoidance.html fast/multicol/vertical-lr/float-avoidance.html
Dave Hyatt
Comment 6 2011-10-04 11:16:25 PDT
Fixed.
Dave Hyatt
Comment 7 2011-10-04 11:16:42 PDT
The two multicol tests that progressed will need to be rebaselined on all platforms.
Note You need to log in before you can comment on or make changes to this bug.