Bug 69313 - [flexbox] take marginBeforeForChild into account when positioning children
Summary: [flexbox] take marginBeforeForChild into account when positioning children
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-03 19:03 PDT by Ojan Vafai
Modified: 2011-10-05 17:00 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.26 KB, patch)
2011-10-03 19:03 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (6.83 KB, patch)
2011-10-05 16:55 PDT, Ojan Vafai
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-10-03 19:03:03 PDT
[flexbox] take marginBeforeForChild into account when positioning children
Comment 1 Ojan Vafai 2011-10-03 19:03:31 PDT
Created attachment 109570 [details]
Patch
Comment 2 Tony Chang 2011-10-05 14:55:19 PDT
Comment on attachment 109570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109570&action=review

> LayoutTests/css3/flexbox/002.html:34
> +<div data-expected-height="120" class="flexbox">

Did you mean to add data-expected-height here?

> LayoutTests/css3/flexbox/002.html:35
> +  <div data-expected-width="200" data-offset-y="50" style="width: -webkit-flex(1 0 0); margin: 50px 0;"></div>

Can we add a new test case rather than changing a test case?

> LayoutTests/css3/flexbox/writing-modes.html:78
> -  <div data-expected-height="150" data-offset-y="0" style="height: -webkit-flex(1 0 0);"></div>
> +  <div data-expected-height="150" data-offset-y="0" data-offset-x="50" style="height: -webkit-flex(1 0 0); margin: 0 100px 0 50px;"></div>

Ditto.

> LayoutTests/css3/flexbox/writing-modes.html:164
> -  <div data-expected-height="150" data-offset-y="0" data-offset-x="580" style="height: -webkit-flex(1 0 0);"></div>
> +  <div data-expected-height="150" data-offset-y="0" data-offset-x="480" style="height: -webkit-flex(1 0 0); margin: 0 100px 0 50px;"></div>

Ditto.

> LayoutTests/css3/flexbox/writing-modes.html:172
> -  <div data-expected-width="150" data-offset-y="180" data-offset-x="0" style="width: -webkit-flex(1 0 0);"></div>
> +  <div data-expected-width="150" data-offset-y="130" data-offset-x="0" style="width: -webkit-flex(1 0 0); margin: 100px 0 50px 0;"></div>

Ditto.
Comment 3 Ojan Vafai 2011-10-05 16:55:39 PDT
Created attachment 109882 [details]
Patch
Comment 4 Ojan Vafai 2011-10-05 17:00:29 PDT
Committed r96769: <http://trac.webkit.org/changeset/96769>