Remove setShouldPaintCustomScrollbars, which has no callers
Created attachment 109542 [details] Patch
Comment on attachment 109542 [details] Patch Attachment 109542 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9944040
Looks like this function does have at least one caller: Source/WebKit/chromium/webkit/glue/webpreferences.cc: In member function 'void WebPreferences::Apply(WebKit::WebView*) const': Source/WebKit/chromium/webkit/glue/webpreferences.cc:217: error: 'class WebKit::WebSettings' has no member named 'setShouldPaintCustomScrollbars'
Despite appearances, that function is actually located here: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.cc?view=markup
abarth: andersca: does the setShouldPaintCustomScrollbars now have the behavior of being true or false? andersca_: abarth|gardener: false abarth|gardener: that seems problematic because http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.cc?view=markup sets it to true andersca_: abarth|gardener: custom scrollbars really meant "should delegate painting scrollbars to the client" abarth|gardener: // Turn this on to cause WebCore to paint the resize corner for us. abarth|gardener: settings->setShouldPaintCustomScrollbars(true); andersca_: abarth|gardener: you should be able to remove that - the resize corner will be painted anyway abarth|gardener: sounds like the author of that code was confused andersca_: yup abarth|gardener: okiedokes
Removing the callers is http://codereview.chromium.org/8122010/
Comment on attachment 109542 [details] Patch Clearing flags on attachment: 109542 Committed r96946: <http://trac.webkit.org/changeset/96946>
All reviewed patches have been landed. Closing bug.