RESOLVED FIXED Bug 69300
[Chromium] Remove setShouldPaintCustomScrollbars, which has no callers 
https://bugs.webkit.org/show_bug.cgi?id=69300
Summary [Chromium] Remove setShouldPaintCustomScrollbars, which has no callers
Adam Barth
Reported 2011-10-03 15:40:18 PDT
Remove setShouldPaintCustomScrollbars, which has no callers
Attachments
Patch (2.72 KB, patch)
2011-10-03 15:41 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-10-03 15:41:04 PDT
Created attachment 109542 [details] Patch
WebKit Review Bot
Comment 2 2011-10-03 16:19:42 PDT
Comment on attachment 109542 [details] Patch Attachment 109542 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9944040
Adam Barth
Comment 3 2011-10-03 16:20:50 PDT
Looks like this function does have at least one caller: Source/WebKit/chromium/webkit/glue/webpreferences.cc: In member function 'void WebPreferences::Apply(WebKit::WebView*) const': Source/WebKit/chromium/webkit/glue/webpreferences.cc:217: error: 'class WebKit::WebSettings' has no member named 'setShouldPaintCustomScrollbars'
Adam Barth
Comment 4 2011-10-03 16:21:41 PDT
Despite appearances, that function is actually located here: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.cc?view=markup
Adam Barth
Comment 5 2011-10-03 16:27:06 PDT
abarth: andersca: does the setShouldPaintCustomScrollbars now have the behavior of being true or false? andersca_: abarth|gardener: false abarth|gardener: that seems problematic because http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.cc?view=markup sets it to true andersca_: abarth|gardener: custom scrollbars really meant "should delegate painting scrollbars to the client" abarth|gardener: // Turn this on to cause WebCore to paint the resize corner for us. abarth|gardener: settings->setShouldPaintCustomScrollbars(true); andersca_: abarth|gardener: you should be able to remove that - the resize corner will be painted anyway abarth|gardener: sounds like the author of that code was confused andersca_: yup abarth|gardener: okiedokes
Adam Barth
Comment 6 2011-10-03 16:29:26 PDT
Removing the callers is http://codereview.chromium.org/8122010/
WebKit Review Bot
Comment 7 2011-10-07 09:34:36 PDT
Comment on attachment 109542 [details] Patch Clearing flags on attachment: 109542 Committed r96946: <http://trac.webkit.org/changeset/96946>
WebKit Review Bot
Comment 8 2011-10-07 09:34:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.