Bug 69278 - CSS 2.1 failure: block-non-replaced-width-008.htm
Summary: CSS 2.1 failure: block-non-replaced-width-008.htm
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Hogan
URL: http://test.csswg.org/suites/css2.1/n...
Depends on:
Blocks: 47141
  Show dependency treegraph
Reported: 2011-10-03 12:09 PDT by Robert Hogan
Modified: 2011-10-29 15:04 PDT (History)
6 users (show)

See Also:

Patch (19.76 KB, patch)
2011-10-03 13:37 PDT, Robert Hogan
no flags Details | Formatted Diff | Diff
Patch (20.05 KB, patch)
2011-10-04 12:20 PDT, Robert Hogan
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2011-10-03 12:09:24 PDT
The checked-in results for this test show a failure.
Comment 1 Robert Hogan 2011-10-03 13:37:08 PDT
Created attachment 109519 [details]
Comment 2 Robert Hogan 2011-10-04 12:20:21 PDT
Created attachment 109664 [details]
Comment 3 Simon Fraser (smfr) 2011-10-24 13:20:12 PDT
Comment on attachment 109664 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=109664&action=review

> Source/WebCore/ChangeLog:11
> +          Include the margins in the calculation of logical width even when the containing block's
> +          width is zero. This is required by block-non-replaced-width-008.htm in the CSS test suite.

It would be better to refer to the section of the CSS 2.1 spec that requires this, not the test that is fixed by the change.
Comment 4 Robert Hogan 2011-10-29 12:17:01 PDT
Committed r98812: <http://trac.webkit.org/changeset/98812>
Comment 5 Ryosuke Niwa 2011-10-29 14:06:32 PDT
css2.1/20110323/block-non-replaced-width-008.htm and fast/replaced/width100percent-searchfield.html appear to have started failing after this patch:

Could you rebaseline or skip them?
Comment 6 Ryosuke Niwa 2011-10-29 15:04:27 PDT
Mac rebaseline done in http://trac.webkit.org/changeset/98818.