Bug 69270 – [Chromium] Fix position check for double tap gesture detection

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Varun Jain]

Fix position check for double tap gesture detection

[Varun Jain]

Created attachment 109512 [details]
Patch

[Robert Kroeger]

Comment on attachment 109512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109512&action=review

Looks largely ok to me.

> ChangeLog:4
> +        should not be detected if thw two taps are far from each other.

typo: thw

> Source/WebCore/platform/chromium/GestureRecognizerChromium.h:97
> +    IntPoint m_lastClickPosition;

At some point, this will all need to be refactored. But not now.

> Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp:382
> +#if OS(MAC_OS_X)

How about looking into why later? (There's already a bug for it.)

[Varun Jain]

Created attachment 109523 [details]
Patch

[Varun Jain]

(In reply to comment #2)
> (From update of attachment 109512 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109512&action=review
> 
> Looks largely ok to me.
> 
> > ChangeLog:4
> > +        should not be detected if thw two taps are far from each other.
> 
> typo: thw

Done

> 
> > Source/WebCore/platform/chromium/GestureRecognizerChromium.h:97
> > +    IntPoint m_lastClickPosition;
> 
> At some point, this will all need to be refactored. But not now.
> 
> > Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp:382
> > +#if OS(MAC_OS_X)
> 
> How about looking into why later? (There's already a bug for it.)

Yes I do plan to look into this later (if you do not get to it first)

[Varun Jain]

Created attachment 109537 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 109537 [details]
Patch

OK

[WebKit Review Bot]

Comment on attachment 109537 [details]
Patch

Clearing flags on attachment: 109537

Committed r96657: <http://trac.webkit.org/changeset/96657>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.