Bug 69270 - [Chromium] Fix position check for double tap gesture detection
: [Chromium] Fix position check for double tap gesture detection
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Varun Jain
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-03 11:19 PDT by Varun Jain
Modified: 2011-10-04 15:47 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.84 KB, patch)
2011-10-03 13:02 PDT, Varun Jain
no flags Details | Formatted Diff | Diff
Patch (10.84 KB, patch)
2011-10-03 13:44 PDT, Varun Jain
no flags Details | Formatted Diff | Diff
Patch (13.54 KB, patch)
2011-10-03 15:11 PDT, Varun Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Varun Jain 2011-10-03 11:19:00 PDT
Fix position check for double tap gesture detection
Comment 1 Varun Jain 2011-10-03 13:02:01 PDT
Created attachment 109512 [details]
Patch
Comment 2 Robert Kroeger 2011-10-03 13:34:44 PDT
Comment on attachment 109512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109512&action=review

Looks largely ok to me.

> ChangeLog:4
> +        should not be detected if thw two taps are far from each other.

typo: thw

> Source/WebCore/platform/chromium/GestureRecognizerChromium.h:97
> +    IntPoint m_lastClickPosition;

At some point, this will all need to be refactored. But not now.

> Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp:382
> +#if OS(MAC_OS_X)

How about looking into why later? (There's already a bug for it.)
Comment 3 Varun Jain 2011-10-03 13:44:46 PDT
Created attachment 109523 [details]
Patch
Comment 4 Varun Jain 2011-10-03 13:45:30 PDT
(In reply to comment #2)
> (From update of attachment 109512 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109512&action=review
> 
> Looks largely ok to me.
> 
> > ChangeLog:4
> > +        should not be detected if thw two taps are far from each other.
> 
> typo: thw

Done

> 
> > Source/WebCore/platform/chromium/GestureRecognizerChromium.h:97
> > +    IntPoint m_lastClickPosition;
> 
> At some point, this will all need to be refactored. But not now.
> 
> > Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp:382
> > +#if OS(MAC_OS_X)
> 
> How about looking into why later? (There's already a bug for it.)

Yes I do plan to look into this later (if you do not get to it first)
Comment 5 Varun Jain 2011-10-03 15:11:03 PDT
Created attachment 109537 [details]
Patch
Comment 6 Darin Fisher (:fishd, Google) 2011-10-04 15:05:49 PDT
Comment on attachment 109537 [details]
Patch

OK
Comment 7 WebKit Review Bot 2011-10-04 15:47:23 PDT
Comment on attachment 109537 [details]
Patch

Clearing flags on attachment: 109537

Committed r96657: <http://trac.webkit.org/changeset/96657>
Comment 8 WebKit Review Bot 2011-10-04 15:47:29 PDT
All reviewed patches have been landed.  Closing bug.