Bug 69270 - [Chromium] Fix position check for double tap gesture detection
: [Chromium] Fix position check for double tap gesture detection
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-10-03 11:19 PST by
Modified: 2011-10-04 15:47 PST (History)


Attachments
Patch (10.84 KB, patch)
2011-10-03 13:02 PST, Varun Jain
no flags Review Patch | Details | Formatted Diff | Diff
Patch (10.84 KB, patch)
2011-10-03 13:44 PST, Varun Jain
no flags Review Patch | Details | Formatted Diff | Diff
Patch (13.54 KB, patch)
2011-10-03 15:11 PST, Varun Jain
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-10-03 11:19:00 PST
Fix position check for double tap gesture detection
------- Comment #1 From 2011-10-03 13:02:01 PST -------
Created an attachment (id=109512) [details]
Patch
------- Comment #2 From 2011-10-03 13:34:44 PST -------
(From update of attachment 109512 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=109512&action=review

Looks largely ok to me.

> ChangeLog:4
> +        should not be detected if thw two taps are far from each other.

typo: thw

> Source/WebCore/platform/chromium/GestureRecognizerChromium.h:97
> +    IntPoint m_lastClickPosition;

At some point, this will all need to be refactored. But not now.

> Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp:382
> +#if OS(MAC_OS_X)

How about looking into why later? (There's already a bug for it.)
------- Comment #3 From 2011-10-03 13:44:46 PST -------
Created an attachment (id=109523) [details]
Patch
------- Comment #4 From 2011-10-03 13:45:30 PST -------
(In reply to comment #2)
> (From update of attachment 109512 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109512&action=review
> 
> Looks largely ok to me.
> 
> > ChangeLog:4
> > +        should not be detected if thw two taps are far from each other.
> 
> typo: thw

Done

> 
> > Source/WebCore/platform/chromium/GestureRecognizerChromium.h:97
> > +    IntPoint m_lastClickPosition;
> 
> At some point, this will all need to be refactored. But not now.
> 
> > Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp:382
> > +#if OS(MAC_OS_X)
> 
> How about looking into why later? (There's already a bug for it.)

Yes I do plan to look into this later (if you do not get to it first)
------- Comment #5 From 2011-10-03 15:11:03 PST -------
Created an attachment (id=109537) [details]
Patch
------- Comment #6 From 2011-10-04 15:05:49 PST -------
(From update of attachment 109537 [details])
OK
------- Comment #7 From 2011-10-04 15:47:23 PST -------
(From update of attachment 109537 [details])
Clearing flags on attachment: 109537

Committed r96657: <http://trac.webkit.org/changeset/96657>
------- Comment #8 From 2011-10-04 15:47:29 PST -------
All reviewed patches have been landed.  Closing bug.