Bug 69269 - Web Inspector: add DebuggerPresentationModel and ConsoleView to compilation.
Summary: Web Inspector: add DebuggerPresentationModel and ConsoleView to compilation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-03 11:06 PDT by Pavel Feldman
Modified: 2011-10-04 01:36 PDT (History)
12 users (show)

See Also:


Attachments
Patch (28.50 KB, patch)
2011-10-03 11:08 PDT, Pavel Feldman
yurys: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-10-03 11:06:38 PDT
Patch to follow. Btw, this compilation round found a bug introduced in r96500.
Comment 1 Pavel Feldman 2011-10-03 11:08:14 PDT
Created attachment 109497 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-03 11:29:19 PDT
Comment on attachment 109497 [details]
Patch

Attachment 109497 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9942004

New failing tests:
http/tests/inspector/network/network-disabling-check-no-memory-leak.html
http/tests/inspector/network/network-iframe-load-and-delete.html
http/tests/inspector/console-xhr-logging.html
http/tests/inspector/network/network-cachedresources-with-same-urls.html
http/tests/inspector/console-cd.html
http/tests/inspector/network/network-disable-cache-memory.html
http/tests/inspector/resource-har-headers.html
http/tests/inspector/network/network-disable-cache-xhrs.html
http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html
http/tests/inspector/inspect-iframe-from-different-domain.html
http/tests/inspector-enabled/console-log-before-frame-navigation.html
http/tests/inspector/network-preflight-options.html
http/tests/inspector/network/network-content-replacement-xhr.html
http/tests/inspector/console-cd-completions.html
http/tests/inspector-enabled/dom-storage-open.html
http/tests/inspector/resource-har-conversion.html
http/tests/inspector/console-resource-errors.html
http/tests/inspector/resource-parameters.html
http/tests/inspector-enabled/database-open.html
http/tests/inspector/change-iframe-src.html
Comment 3 Pavel Feldman 2011-10-04 01:36:15 PDT
Committed r96575: <http://trac.webkit.org/changeset/96575>