Bug 69253 - Web Inspector: more compilation fixes including making ConsoleMessage a part of console model.
Summary: Web Inspector: more compilation fixes including making ConsoleMessage a part ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-03 05:19 PDT by Pavel Feldman
Modified: 2011-10-03 07:55 PDT (History)
10 users (show)

See Also:


Attachments
Patch (31.72 KB, patch)
2011-10-03 05:42 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[Patch] Review comments addressed (35.19 KB, patch)
2011-10-03 07:28 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-10-03 05:19:23 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-10-03 05:42:54 PDT
Created attachment 109474 [details]
Patch
Comment 2 Yury Semikhatsky 2011-10-03 06:59:37 PDT
Comment on attachment 109474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109474&action=review

> Source/WebCore/inspector/Inspector.json:555
> +                    { "name": "requestKey3", "type": "string", "description": "HTTP response status text." },

What is requestKey3, please chose a better name.

> Source/WebCore/inspector/front-end/ConsoleMessage.js:49
> +WebInspector.ConsoleMessageImpl = function(source, type, level, line, url, repeatCount, message, parameters, stackTrace, request)

Let's extract UI-independent parts of the ConsoleMessageImpl into ConsoleMessage as agreed offline.
Comment 3 Pavel Feldman 2011-10-03 07:28:07 PDT
Created attachment 109481 [details]
[Patch] Review comments addressed
Comment 4 Yury Semikhatsky 2011-10-03 07:44:40 PDT
Comment on attachment 109481 [details]
[Patch] Review comments addressed

View in context: https://bugs.webkit.org/attachment.cgi?id=109481&action=review

> Source/WebCore/inspector/front-end/ConsoleModel.js:119
>              msg.repeatCount = msg.repeatCount + msg.repeatDelta;

Setters for these fields are missing in ConsoleMessage.
Comment 5 Pavel Feldman 2011-10-03 07:55:35 PDT
Committed r96499: <http://trac.webkit.org/changeset/96499>