Editor class has two difference code paths for spell-checking: (1) checkTextOfParagraph() for Snow Leopard or later (2) checkSpellingOfString() and checkGrammarOfString() for other platforms. These paths should be unified so that improving spell-checking code is easy. At the first step, we should call checkTextOfParagraph() indirectly so that we can implement a function to mimic checkTextOfParagraph() in non-SL or non-Lion platform.
Created attachment 109440 [details] Patch
Comment on attachment 109440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109440&action=review > Source/WebCore/ChangeLog:12 > + At the first step, this patch introduces an indirect wrappero to call Typo: wrappero > Source/WebCore/editing/TextCheckingHelper.h:96 > + TextCheckingTypeMask checkingTypes, Vector<TextCheckingResult>& results); Nit: indentation is wrong here. TextCheckingTypeMask should be indented by exactly 4 spaces, and should NOT be aligned with TextCheckerClient.
Created attachment 109454 [details] Patch
Comment on attachment 109454 [details] Patch Clearing flags on attachment: 109454 Committed r96568: <http://trac.webkit.org/changeset/96568>
All reviewed patches have been landed. Closing bug.
This patch broke builds pretty badly :( build fixes: http://trac.webkit.org/changeset/96570 http://trac.webkit.org/changeset/96571