Bug 69241 - Should call checkTextOfParagraph() indirectly to make unifying spell-checking code path ease
: Should call checkTextOfParagraph() indirectly to make unifying spell-checking...
Status: RESOLVED FIXED
: WebKit
HTML Editing
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 69128
  Show dependency treegraph
 
Reported: 2011-10-02 22:48 PST by
Modified: 2011-10-03 21:16 PST (History)


Attachments
Patch (7.60 KB, patch)
2011-10-02 23:03 PST, Shinya Kawanaka
no flags Review Patch | Details | Formatted Diff | Diff
Patch (7.57 KB, patch)
2011-10-03 02:23 PST, Shinya Kawanaka
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-10-02 22:48:01 PST
Editor class has two difference code paths for spell-checking:
(1) checkTextOfParagraph() for Snow Leopard or later
(2) checkSpellingOfString() and checkGrammarOfString() for other platforms.
These paths should be unified so that improving spell-checking code is easy.

At the first step, we should call checkTextOfParagraph() indirectly so that we can implement a function to mimic checkTextOfParagraph() in non-SL or non-Lion platform.
------- Comment #1 From 2011-10-02 23:03:25 PST -------
Created an attachment (id=109440) [details]
Patch
------- Comment #2 From 2011-10-02 23:33:22 PST -------
(From update of attachment 109440 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=109440&action=review

> Source/WebCore/ChangeLog:12
> +        At the first step, this patch introduces an indirect wrappero to call

Typo: wrappero

> Source/WebCore/editing/TextCheckingHelper.h:96
> +                          TextCheckingTypeMask checkingTypes, Vector<TextCheckingResult>& results);

Nit: indentation is wrong here. TextCheckingTypeMask should be indented by exactly 4 spaces, and should NOT be aligned with TextCheckerClient.
------- Comment #3 From 2011-10-03 02:23:48 PST -------
Created an attachment (id=109454) [details]
Patch
------- Comment #4 From 2011-10-03 20:10:00 PST -------
(From update of attachment 109454 [details])
Clearing flags on attachment: 109454

Committed r96568: <http://trac.webkit.org/changeset/96568>
------- Comment #5 From 2011-10-03 20:10:04 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #6 From 2011-10-03 21:16:21 PST -------
This patch broke builds pretty badly :(

build fixes:
http://trac.webkit.org/changeset/96570
http://trac.webkit.org/changeset/96571