Bug 69230 - Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
Summary: Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::match...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-02 16:41 PDT by Sam Weinig
Modified: 2011-10-02 17:39 PDT (History)
0 users

See Also:


Attachments
Patch (30.83 KB, patch)
2011-10-02 16:44 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-10-02 16:41:56 PDT
Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
Comment 1 Sam Weinig 2011-10-02 16:44:38 PDT
Created attachment 109431 [details]
Patch
Comment 2 Anders Carlsson 2011-10-02 17:33:25 PDT
Comment on attachment 109431 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109431&action=review

> Source/WebKit/mac/WebView/WebHTMLRepresentation.mm:537
> +    // FIXME: This code is mirrored in Frame.cpp. It would be nice to make the Mac code call the platform-agnostic
> +    // code, which would require converting the NSArray of NSStrings to a Vector of Strings somewhere along the way.

Is this comment still relevant?
Comment 3 Sam Weinig 2011-10-02 17:39:40 PDT
Committed r96480: <http://trac.webkit.org/changeset/96480>