Bug 69221 - Web Inspector: restore partial front-end compilability
Summary: Web Inspector: restore partial front-end compilability
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-02 04:56 PDT by Pavel Feldman
Modified: 2011-10-03 02:15 PDT (History)
10 users (show)

See Also:


Attachments
Patch (20.58 KB, patch)
2011-10-02 05:00 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-10-02 04:56:48 PDT
Removed unused isWhitespace; introduced missing classes in Inspector.json.
Comment 1 Pavel Feldman 2011-10-02 05:00:03 PDT
Created attachment 109419 [details]
Patch
Comment 2 Yury Semikhatsky 2011-10-03 00:54:09 PDT
Comment on attachment 109419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109419&action=review

> Source/WebCore/inspector/front-end/DOMAgent.js:389
> +    /** @type {Object|undefined} */

When can it become undefined?

> Source/WebCore/inspector/front-end/Object.js:71
> +     * @param {*=} eventData

Should be just {*}
Comment 3 Pavel Feldman 2011-10-03 02:15:21 PDT
Committed r96485: <http://trac.webkit.org/changeset/96485>