Bug 69202 - [CSS3 Regions] Make positioned objects work properly with regions.
Summary: [CSS3 Regions] Make positioned objects work properly with regions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 57312
  Show dependency treegraph
 
Reported: 2011-09-30 18:18 PDT by Dave Hyatt
Modified: 2012-07-23 23:16 PDT (History)
3 users (show)

See Also:


Attachments
Patch (223.54 KB, patch)
2011-09-30 18:20 PDT, Dave Hyatt
sam: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2011-09-30 18:18:42 PDT
Positioned objects need to use the first region as the ICB and behave properly in variable width regions.
Comment 1 Dave Hyatt 2011-09-30 18:20:28 PDT
Created attachment 109387 [details]
Patch
Comment 2 Sam Weinig 2011-09-30 18:31:05 PDT
Comment on attachment 109387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109387&action=review

> Source/WebCore/rendering/RenderBlock.h:266
> +    LayoutUnit startOffsetForContent(LayoutUnit position) const { return style()->isLeftToRightDirection() ? logicalLeftOffsetForContent(position) :width() - logicalRightOffsetForContent(position); }

There should be a space after the :.
Comment 3 WebKit Review Bot 2011-09-30 18:53:10 PDT
Comment on attachment 109387 [details]
Patch

Attachment 109387 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9898574

New failing tests:
fast/block/positioning/auto/vertical-lr/004.html
fast/block/positioning/auto/vertical-rl/003.html
fast/block/positioning/auto/vertical-rl/004.html
fast/block/positioning/auto/vertical-lr/003.html
Comment 4 Dave Hyatt 2011-09-30 20:07:07 PDT
Fixed in r96452 (the width() in startOffsetForContent turned into a logicalWidth() to fix those failing layout tests).