Bug 69191 - [WinCairo] Correct build settings to allow DumpRenderTree (etc) to run
Summary: [WinCairo] Correct build settings to allow DumpRenderTree (etc) to run
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-30 17:04 PDT by Brent Fulgham
Modified: 2011-10-01 21:35 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.75 KB, patch)
2011-09-30 17:07 PDT, Brent Fulgham
bweinstein: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2011-09-30 17:04:59 PDT
The existing project files are set up so that DumpRenderTree's post-build step copies various necessary files to the target location, which allows tests, etc., to run.

Unfortunately, the WinCairo target does not use CoreFoundation.dll, and therefore skips the file copy step.

This change modifies the post-build step so that the CFLite.dll case is handled properly.
Comment 1 Brent Fulgham 2011-09-30 17:07:38 PDT
Created attachment 109376 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-01 00:59:08 PDT
Comment on attachment 109376 [details]
Patch

Rejecting attachment 109376 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
iewer', u'Brian Weinstein', u'--..." exit_code: 1

Parsed 2 diffs from patch file(s).
patching file TOols/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file TOols/DumpRenderTree/win/DumpRenderTreePostBuild.cmd
Hunk #1 FAILED at 4.
Hunk #2 FAILED at 36.
2 out of 2 hunks FAILED -- saving rejects to file TOols/DumpRenderTree/win/DumpRenderTreePostBuild.cmd.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Brian Weinstein', u'--..." exit_code: 1

Full output: http://queues.webkit.org/results/9901619
Comment 3 Brent Fulgham 2011-10-01 21:35:14 PDT
Landed in r96468.