Bug 69166 – Inset focus ring (Skia on Mac)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Cary Clark]

Inset focus ring (Skia on Mac)

[Cary Clark]

Created attachment 109338 [details]
Patch

[Stephen White]

Comment on attachment 109338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109338&action=review

The constants seem a little mysterious (although no more mysterious than they were before).  A comment would be nice.  r=me

> Source/WebCore/ChangeLog:13
> +        No new tests. This platform is not enabled.

Nit:  It would be nice to know which tests will exercise this when the platform is enabled (if any).

[WebKit Review Bot]

Comment on attachment 109338 [details]
Patch

Clearing flags on attachment: 109338

Committed r96426: <http://trac.webkit.org/changeset/96426>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Barth]

I assume you know this will require a ton of rebaselines.

[Adam Barth]

Comment on attachment 109338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109338&action=review

>> Source/WebCore/ChangeLog:13
>> +        No new tests. This platform is not enabled.
> 
> Nit:  It would be nice to know which tests will exercise this when the platform is enabled (if any).

I don't understand this comment.  This patch effects the Chromium Mac Skia build, which you've asked the WebKit gardener (i.e., me) to maintain.  In any case, I'll give you an exact list of the tests it effects in a few minutes.

[Adam Barth]

Here as the lists of results expected:


editing/style/5279521-expected.png
editing/style/5046875-1-expected.png
editing/style/style-3998892-fix-expected.png
editing/style/highlight-expected.png
editing/style/typing-style-002-expected.png
editing/style/style-3681552-fix-002-expected.txt
editing/style/4916887-expected.png
editing/style/style-3681552-fix-001-expected.png
editing/style/style-boundary-002-expected.png
editing/style/style-boundary-004-expected.png
editing/style/5017613-1-expected.png
editing/style/5228141-expected.png
editing/style/5046875-2-expected.png
editing/style/unbold-in-bold-expected.png
editing/style/typing-style-001-expected.png
editing/style/style-3681552-fix-002-expected.png
editing/style/block-styles-007-expected.png
editing/style/style-boundary-001-expected.png
editing/style/style-boundary-003-expected.png
editing/style/style-boundary-005-expected.png
editing/style/5017613-2-expected.png
editing/style/5084241-expected.png
editing/style/smoosh-styles-001-expected.png
editing/style/5065910-expected.png
editing/unsupported-content/table-type-after-expected.png
editing/unsupported-content/table-delete-001-expected.png
editing/unsupported-content/table-type-before-expected.png
editing/unsupported-content/table-delete-002-expected.png
editing/unsupported-content/table-delete-003-expected.png
editing/unsupported-content/list-delete-001-expected.png
editing/unsupported-content/list-type-after-expected.png
editing/unsupported-content/list-type-before-expected.png
editing/unsupported-content/list-delete-003-expected.png
editing/inserting/4840662-expected.png
editing/inserting/typing-around-br-001-expected.png
editing/inserting/return-key-with-selection-003-expected.png
editing/inserting/insert-br-quoted-002-expected.png
editing/inserting/insert-br-002-expected.png
editing/inserting/insert-br-quoted-006-expected.png
editing/inserting/insert-br-006-expected.png
editing/inserting/insert-tab-003-expected.png
editing/inserting/typing-002-expected.png
editing/inserting/insert-3800346-fix-expected.png
editing/inserting/insert-text-at-tabspan-003-expected.png
editing/inserting/typing-around-image-001-expected.png
editing/inserting/insert-text-with-newlines-expected.png
editing/inserting/4960120-1-expected.png
editing/inserting/insert-paragraph-04-expected.png
editing/inserting/insert-at-end-02-expected.png
editing/inserting/5058163-2-expected.png
editing/inserting/insert-br-at-tabspan-003-expected.png
editing/inserting/6703873-expected.png
editing/inserting/insert-br-quoted-003-expected.png
editing/inserting/insert-br-003-expected.png
editing/inserting/4875189-1-expected.png
editing/inserting/insert-tab-004-expected.png
editing/inserting/insert-br-007-expected.png
editing/inserting/typing-003-expected.png
editing/inserting/editable-inline-element-expected.png
editing/inserting/paragraph-separator-01-expected.png
editing/inserting/5156401-2-expected.png
editing/inserting/4960120-2-expected.png
editing/inserting/before-after-input-element-expected.png
editing/inserting/insert-paragraph-01-expected.png
editing/inserting/5510537-expected.png
editing/inserting/insert-paragraph-05-expected.png
editing/inserting/multiple-lines-selected-expected.png
editing/inserting/insert-3778059-fix-expected.png
editing/inserting/return-key-with-selection-001-expected.png
editing/inserting/insert-br-quoted-004-expected.png
editing/inserting/insert-tab-001-expected.png
editing/inserting/insert-br-004-expected.png
editing/inserting/4959067-expected.png
editing/inserting/4875189-2-expected.png
editing/inserting/5549929-2-expected.png
editing/inserting/insert-br-008-expected.png
editing/inserting/insert-text-at-tabspan-001-expected.png
editing/inserting/paragraph-separator-02-expected.png
editing/inserting/editing-empty-divs-expected.png
editing/inserting/insert-paragraph-02-expected.png
editing/inserting/insert-div-025-expected.png
editing/inserting/paragraph-separator-in-table-1-expected.png
editing/inserting/insert-br-at-tabspan-001-expected.png
editing/inserting/insert-space-in-empty-doc-expected.png
editing/inserting/return-key-with-selection-002-expected.png
editing/inserting/insert-after-delete-001-expected.png
editing/inserting/insert-br-quoted-001-expected.png
editing/inserting/insert-br-001-expected.png
editing/inserting/5418891-expected.png
editing/inserting/insert-br-quoted-005-expected.png
editing/inserting/insert-br-005-expected.png
editing/inserting/insert-tab-002-expected.png
editing/inserting/typing-001-expected.png
editing/inserting/line-break-expected.png
editing/inserting/5549929-3-expected.png
editing/inserting/insert-br-009-expected.png
editing/inserting/4278698-expected.png
editing/inserting/insert-text-at-tabspan-002-expected.png
editing/inserting/5002441-expected.png
editing/inserting/paragraph-separator-03-expected.png
editing/inserting/insert-3775316-fix-expected.png
editing/inserting/edited-whitespace-1-expected.png
editing/inserting/insert-paragraph-03-expected.png
editing/inserting/insert-at-end-01-expected.png
editing/inserting/5058163-1-expected.png
editing/inserting/break-blockquote-after-delete-expected.png
editing/inserting/insert-div-026-expected.png
editing/inserting/redo-expected.png
editing/inserting/paragraph-separator-in-table-2-expected.png
editing/inserting/insert-br-at-tabspan-002-expected.png
editing/execCommand/indent-empty-root-expected.png
editing/execCommand/4580583-1-expected.png
editing/execCommand/4747450-expected.png
editing/execCommand/indent-selection-expected.png
editing/execCommand/selectAll-expected.png
editing/execCommand/5142012-1-expected.png
editing/execCommand/nsresponder-indent-expected.png
editing/execCommand/5080333-1-expected.png
editing/execCommand/remove-list-from-range-selection-expected.png
editing/execCommand/indent-list-item-expected.png
editing/execCommand/5138441-expected.png
editing/execCommand/4916402-expected.png
editing/execCommand/4924441-expected.png
editing/execCommand/5481523-expected.png
editing/execCommand/print-expected.png
editing/execCommand/5136770-expected.png
editing/execCommand/create-list-with-hr-expected.png
editing/execCommand/4916541-expected.png
editing/execCommand/4641880-2-expected.png
editing/execCommand/4580583-2-expected.png
editing/execCommand/remove-list-item-1-expected.png
editing/execCommand/format-block-with-trailing-br-expected.png
editing/execCommand/5569741-expected.png
editing/execCommand/insertHorizontalRule-expected.png
editing/execCommand/insertImage-expected.png
editing/execCommand/insert-list-and-stitch-expected.png
editing/execCommand/nsresponder-outdent-expected.png
editing/execCommand/5080333-2-expected.png
editing/execCommand/4641880-1-expected.png
editing/pasteboard/4076267-3-expected.png
editing/pasteboard/4076267-expected.png
editing/pasteboard/5134759-expected.png
editing/pasteboard/cut-text-001-expected.png
editing/pasteboard/5156401-1-expected.png
editing/pasteboard/4641033-expected.png
editing/pasteboard/5032095-expected.png
editing/pasteboard/paste-line-endings-004-expected.png
editing/pasteboard/5247341-expected.png
editing/pasteboard/paste-4035648-fix-expected.png
editing/pasteboard/paste-line-endings-008-expected.png
editing/pasteboard/8145-1-expected.png
editing/pasteboard/4944770-1-expected.png
editing/pasteboard/5075944-expected.png
editing/pasteboard/paste-match-style-001-expected.png
editing/pasteboard/smart-paste-007-expected.png
editing/pasteboard/paste-text-019-expected.png
editing/pasteboard/undoable-fragment-removes-expected.png
editing/pasteboard/merge-end-blockquote-expected.png
editing/pasteboard/input-field-1-expected.png
editing/pasteboard/paste-line-endings-001-expected.png
editing/pasteboard/paste-line-endings-005-expected.png
editing/pasteboard/merge-after-delete-1-expected.png
editing/pasteboard/unrendered-br-expected.png
editing/pasteboard/paste-line-endings-009-expected.png
editing/pasteboard/5478250-expected.png
editing/pasteboard/merge-after-delete-expected.png
editing/pasteboard/quirks-mode-br-1-expected.png
editing/pasteboard/4631972-expected.png
editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png
editing/pasteboard/8145-2-expected.png
editing/pasteboard/4944770-2-expected.png
editing/pasteboard/merge-end-borders-expected.png
editing/pasteboard/paste-match-style-002-expected.png
editing/pasteboard/merge-start-list-expected.png
editing/pasteboard/4806874-expected.png
editing/pasteboard/smart-paste-008-expected.png
editing/pasteboard/drag-selected-image-to-contenteditable-expected.png
editing/pasteboard/bad-placeholder-expected.png
editing/pasteboard/displaced-placeholder-expected.png
editing/pasteboard/3976872-expected.png
editing/pasteboard/pasting-object-expected.png
editing/pasteboard/5387578-expected.png
editing/pasteboard/displaced-generic-placeholder-expected.png
editing/pasteboard/paste-line-endings-010-expected.png
editing/pasteboard/paste-line-endings-002-expected.png
editing/pasteboard/5071074-2-expected.png
editing/pasteboard/4242293-expected.png
editing/pasteboard/5601583-1-expected.png
editing/pasteboard/paste-line-endings-006-expected.png
editing/pasteboard/4947130-expected.png
editing/pasteboard/pasting-tabs-expected.png
editing/pasteboard/merge-after-delete-2-expected.png
editing/pasteboard/4076267-2-expected.png
editing/pasteboard/merge-start-blockquote-expected.png
editing/pasteboard/5006779-expected.png
editing/pasteboard/8145-3-expected.png
editing/pasteboard/smart-drag-drop-expected.png
editing/pasteboard/drop-text-without-selection-expected.png
editing/pasteboard/paste-line-endings-003-expected.png
editing/pasteboard/drag-drop-modifies-page-expected.png
editing/pasteboard/paste-text-at-tabspan-003-expected.png
editing/pasteboard/paste-blockquote-after-blockquote-expected.png
editing/pasteboard/5071074-expected.png
editing/pasteboard/styled-element-markup-expected.png
editing/pasteboard/paste-line-endings-007-expected.png
editing/pasteboard/paste-4038267-fix-expected.png
editing/selection/contenteditable-click-inside-expected.png
editing/selection/move-by-line-002-expected.png
editing/selection/select-missing-image-expected.png
editing/selection/selection-3748164-fix-expected.png
editing/selection/mixed-editability-5-expected.png
editing/selection/move-by-sentence-001-expected.png
editing/selection/extend-selection-bidi-expected.png
editing/selection/table-caret-1-expected.png
editing/selection/5007143-expected.png
editing/selection/fake-doubleclick-expected.png
editing/selection/caret-ltr-2-left-expected.png
editing/selection/move-by-word-001-expected.png
editing/selection/extend-by-character-001-expected.png
editing/selection/4932260-1-expected.png
editing/selection/5076323-2-expected.png
editing/selection/5234383-2-expected.png
editing/selection/5057506-expected.png
editing/selection/caret-ltr-2-expected.png
editing/selection/4818145-expected.png
editing/selection/move-backwords-by-word-001-expected.png
editing/selection/inline-table-expected.png
editing/selection/4895428-3-expected.png
editing/selection/replaced-boundaries-2-expected.png
editing/selection/caret-ltr-right-expected.png
editing/selection/move-by-character-004-expected.png
editing/selection/caret-before-select-expected.png
editing/selection/4889598-expected.png
editing/selection/select-all-001-expected.png
editing/selection/5131716-4-expected.png
editing/selection/3690703-expected.png
editing/selection/unrendered-003-expected.png
editing/selection/extend-by-character-006-expected.png
editing/selection/caret-ltr-expected.png
editing/selection/iframe-expected.png
editing/selection/move-by-character-001-expected.png
editing/selection/extend-by-word-001-expected.png
editing/selection/mixed-editability-7-expected.png
editing/selection/table-caret-3-expected.png
editing/selection/5131716-1-expected.png
editing/selection/drag-select-1-expected.png
editing/selection/extend-by-character-003-expected.png
editing/selection/4932260-3-expected.png
editing/selection/after-line-wrap-expected.png
editing/selection/move-by-line-001-expected.png
editing/selection/6476-expected.png
editing/selection/contains-boundaries-expected.png
editing/selection/click-start-of-line-expected.png
editing/selection/mixed-editability-4-expected.png
editing/selection/triple-click-in-pre-expected.png
editing/selection/move-past-trailing-space-expected.png
editing/selection/5007143-2-expected.png
editing/selection/5076323-1-expected.png
editing/selection/5234383-1-expected.png
editing/selection/5057506-2-expected.png
editing/selection/unrendered-005-expected.png
editing/selection/5195166-2-expected.png
editing/selection/previous-line-position-expected.png
editing/selection/select-box-expected.png
editing/selection/4895428-2-expected.png
editing/selection/replaced-boundaries-1-expected.png
editing/selection/move-by-character-003-expected.png
editing/selection/move-by-character-6-expected.png
editing/selection/image-before-linebreak-expected.png
editing/selection/mixed-editability-9-expected.png
editing/selection/move-between-blocks-no-001-expected.png
editing/selection/wrapped-line-caret-2-expected.png
editing/selection/caret-rtl-2-left-expected.png
editing/selection/5131716-3-expected.png
editing/selection/3690703-2-expected.png
editing/selection/unrendered-002-expected.png
editing/selection/extend-by-character-005-expected.png
editing/selection/caret-rtl-2-expected.png
editing/selection/iframe-expected.txt
editing/selection/expanding-selections2-expected.png
editing/selection/caret-rtl-right-expected.png
editing/selection/mixed-editability-6-expected.png
editing/selection/13804-expected.png
editing/selection/table-caret-2-expected.png
editing/selection/expanding-selections-expected.png
editing/selection/unrendered-space-expected.png
editing/selection/extend-by-character-002-expected.png
editing/selection/4932260-2-expected.png
editing/selection/5076323-3-expected.png
editing/selection/select-element-paragraph-boundary-expected.png
editing/selection/replace-selection-1-expected.png
editing/selection/caret-rtl-expected.png
editing/selection/extend-by-sentence-001-expected.png
editing/selection/3690719-expected.png
editing/selection/editable-non-editable-crash-expected.png
editing/selection/4397952-expected.png
editing/selection/mixed-editability-3-expected.png
editing/selection/replaced-boundaries-3-expected.png
editing/selection/4947387-expected.png
editing/selection/move-by-sentence-linebreak-expected.png
editing/selection/move-by-character-005-expected.png
editing/selection/select-from-textfield-outwards-expected.png
editing/selection/leave-requested-block-expected.png
editing/selection/end-of-document-expected.png
editing/selection/select-all-002-expected.png
editing/selection/unrendered-004-expected.png
editing/selection/4866671-expected.png
editing/selection/move-by-character-002-expected.png
editing/selection/extend-by-word-002-expected.png
editing/selection/mixed-editability-8-expected.png
editing/selection/wrapped-line-caret-1-expected.png
editing/selection/5131716-2-expected.png
editing/selection/unrendered-001-expected.png
editing/selection/extend-by-character-004-expected.png
editing/selection/5099303-expected.png
editing/undo/redo-typing-001-expected.png
editing/undo/undo-combined-delete-expected.png
editing/undo/5378473-expected.png
editing/undo/undo-combined-delete-boundary-expected.png
editing/undo/undo-delete-expected.png
editing/undo/undo-delete-boundary-expected.png
editing/undo/undo-forward-delete-expected.png
editing/undo/undo-forward-delete-boundary-expected.png
editing/undo/4063751-expected.png
editing/undo/undo-typing-001-expected.png
editing/undo/undo-misspellings-expected.png
editing/deleting/delete-at-paragraph-boundaries-010-expected.png
editing/deleting/5369009-expected.png
editing/deleting/delete-at-paragraph-boundaries-002-expected.png
editing/deleting/4922367-expected.png
editing/deleting/delete-at-paragraph-boundaries-006-expected.png
editing/deleting/delete-br-003-expected.png
editing/deleting/list-item-1-expected.png
editing/deleting/delete-tab-002-expected.png
editing/deleting/delete-br-007-expected.png
editing/deleting/merge-no-br-expected.png
editing/deleting/type-delete-after-quote-expected.png
editing/deleting/5206311-1-expected.png
editing/deleting/delete-image-001-expected.png
editing/deleting/delete-3608462-fix-expected.png
editing/deleting/delete-ws-fixup-003-expected.png
editing/deleting/delete-block-merge-contents-012-expected.png
editing/deleting/delete-block-merge-contents-004-expected.png
editing/deleting/delete-block-contents-001-expected.png
editing/deleting/smart-delete-001-expected.png
editing/deleting/delete-contiguous-ws-001-expected.png
editing/deleting/delete-to-select-table-expected.png
editing/deleting/delete-after-span-ws-001-expected.png
editing/deleting/delete-block-merge-contents-016-expected.png
editing/deleting/delete-block-merge-contents-008-expected.png
editing/deleting/delete-listitem-001-expected.png
editing/deleting/delete-line-015-expected.png
editing/deleting/5433862-2-expected.png
editing/deleting/delete-at-paragraph-boundaries-011-expected.png
editing/deleting/delete-at-paragraph-boundaries-003-expected.png
editing/deleting/delete-br-004-expected.png
editing/deleting/delete-at-paragraph-boundaries-007-expected.png
editing/deleting/delete-tab-003-expected.png
editing/deleting/collapse-whitespace-3587601-fix-expected.png
editing/deleting/pruning-after-merge-2-expected.png
editing/deleting/delete-block-merge-contents-001-expected.png
editing/deleting/delete-line-end-ws-001-expected.png
editing/deleting/delete-image-002-expected.png
editing/deleting/delete-at-start-or-end-expected.png
editing/deleting/delete-block-merge-contents-013-expected.png
editing/deleting/delete-ws-fixup-004-expected.png
editing/deleting/delete-block-contents-002-expected.png
editing/deleting/delete-block-merge-contents-005-expected.png
editing/deleting/smart-delete-002-expected.png
editing/deleting/delete-after-span-ws-002-expected.png
editing/deleting/5272440-expected.png
editing/deleting/table-cells-expected.png
editing/deleting/delete-block-merge-contents-017-expected.png
editing/deleting/delete-block-merge-contents-009-expected.png
editing/deleting/delete-leading-ws-001-expected.png
editing/deleting/delete-listitem-002-expected.png
editing/deleting/delete-character-001-expected.png
editing/deleting/delete-3959464-fix-expected.png
editing/deleting/delete-line-016-expected.png
editing/deleting/5483370-expected.png
editing/deleting/delete-trailing-ws-001-expected.png
editing/deleting/delete-br-001-expected.png
editing/deleting/delete-at-paragraph-boundaries-004-expected.png
editing/deleting/delete-br-013-expected.png
editing/deleting/delete-br-005-expected.png
editing/deleting/delete-at-paragraph-boundaries-008-expected.png
editing/deleting/delete-tab-004-expected.png
editing/deleting/merge-whitespace-pre-expected.png
editing/deleting/merge-endOfParagraph-expected.png
editing/deleting/delete-block-merge-contents-010-expected.png
editing/deleting/delete-ws-fixup-001-expected.png
editing/deleting/delete-block-merge-contents-002-expected.png
editing/deleting/delete-line-end-ws-002-expected.png
editing/deleting/merge-unrendered-space-expected.png
editing/deleting/delete-image-003-expected.png
editing/deleting/delete-selection-001-expected.png
editing/deleting/delete-block-merge-contents-014-expected.png
editing/deleting/merge-different-styles-expected.png
editing/deleting/delete-block-merge-contents-006-expected.png
editing/deleting/delete-block-contents-003-expected.png
editing/deleting/smart-delete-003-expected.png
editing/deleting/delete-after-span-ws-003-expected.png
editing/deleting/merge-into-empty-block-1-expected.png
editing/deleting/delete-first-list-item-expected.png
editing/deleting/delete-line-017-expected.png
editing/deleting/delete-at-paragraph-boundaries-001-expected.png
editing/deleting/delete-trailing-ws-002-expected.png
editing/deleting/delete-at-paragraph-boundaries-005-expected.png
editing/deleting/delete-br-002-expected.png
editing/deleting/delete-tab-001-expected.png
editing/deleting/delete-and-undo-expected.png
editing/deleting/delete-at-paragraph-boundaries-009-expected.png
editing/deleting/delete-br-006-expected.png
editing/deleting/delete-hr-expected.png
editing/deleting/delete-4083333-fix-expected.png
editing/deleting/non-smart-delete-expected.png
editing/deleting/delete-3608445-fix-expected.png
editing/deleting/delete-ws-fixup-002-expected.png
editing/deleting/delete-block-merge-contents-011-expected.png
editing/deleting/delete-block-merge-contents-003-expected.png
editing/deleting/delete-image-004-expected.png
editing/deleting/delete-block-merge-contents-015-expected.png
editing/deleting/delete-block-merge-contents-007-expected.png
editing/deleting/smart-delete-004-expected.png
editing/deleting/merge-into-empty-block-2-expected.png
editing/deleting/5144139-2-expected.png
editing/deleting/5126166-expected.png
editing/deleting/5099303-expected.png
editing/spelling/spelling-expected.png
fast/text/international/rtl-caret-expected.png
fast/text/delete-hard-break-character-expected.png
fast/transforms/transformed-caret-expected.png
fast/transforms/transformed-focused-text-input-expected.png
fast/overflow/overflow-focus-ring-expected.png
fast/events/reveal-link-when-focused-expected.png
fast/events/context-no-deselect-expected.png
fast/events/autoscroll-expected.png
fast/inline/continuation-outlines-expected.png
fast/inline/continuation-outlines-with-layers-2-expected.png
fast/inline/continuation-outlines-with-layers-expected.png
fast/inline/25277-2-expected.png
fast/inline/25277-expected.png
fast/inline/inline-focus-ring-expected.png
fast/dom/focus-contenteditable-expected.png
fast/forms/select-listbox-multiple-no-focusring-expected.png
fast/forms/textfield-outline-expected.png
fast/forms/input-appearance-number-rtl-expected.png
fast/forms/input-text-option-delete-expected.txt
fast/forms/textarea-scrollbar-expected.png
fast/forms/input-placeholder-visibility-2-expected.png
fast/forms/validation-message-appearance-expected.png
fast/forms/input-appearance-focus-expected.png
fast/forms/input-paste-undo-expected.png
fast/forms/input-text-click-inside-expected.png
fast/forms/input-appearance-selection-expected.png
fast/forms/textarea-placeholder-visibility-2-expected.png
fast/forms/input-text-drag-down-expected.png
fast/forms/input-text-double-click-expected.png
fast/forms/input-text-scroll-left-on-blur-expected.png
fast/forms/input-text-self-emptying-click-expected.png
fast/forms/textarea-scrolled-type-expected.png
fast/forms/listbox-hit-test-zoomed-expected.png
fast/forms/plaintext-mode-2-expected.png
fast/forms/input-double-click-selection-gap-bug-expected.png
fast/forms/input-placeholder-visibility-1-expected.png
fast/forms/validation-message-appearance-expected.txt
fast/forms/tabbing-input-iframe-expected.png
fast/forms/textarea-placeholder-visibility-1-expected.png
fast/forms/input-text-option-delete-expected.png
fast/forms/textfield-overflow-expected.png
fast/forms/textfield-focus-ring-expected.png
fast/forms/input-placeholder-visibility-3-expected.png
fast/css/focus-ring-outline-color-expected.png
fast/css/focus-ring-outline-width-expected.png
fast/css/focus-ring-multiline-writingmode-vertical-expected.png
fast/css/focus-ring-outline-offset-expected.png
fast/css/focus-ring-multiline-writingmode-vertical-expected.txt
fast/css/outline-auto-location-expected.png
fast/repaint/focus-layers-expected.png
fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png
fast/repaint/focus-ring-expected.png
fast/frames/take-focus-from-iframe-expected.png
animations/animation-controller-drt-api-expected.txt

[Adam Barth]

I've rolled out this patch in http://trac.webkit.org/changeset/96442

I think there's some sort of miscommunication going on here.  You've asked the WebKit gardener to maintain this configuration, which means it's my job to keep the bots that test this configuration green.  When you land a change like this that causes hundreds of tests to fail, you make that task very difficult, especially when you're not around to communicate with.

[Cary Clark]

Comment on attachment 109338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109338&action=review

>>> Source/WebCore/ChangeLog:13
>>> +        No new tests. This platform is not enabled.
>> 
>> Nit:  It would be nice to know which tests will exercise this when the platform is enabled (if any).
> 
> I don't understand this comment.  This patch effects the Chromium Mac Skia build, which you've asked the WebKit gardener (i.e., me) to maintain.  In any case, I'll give you an exact list of the tests it effects in a few minutes.

The comment at the time was a misunderstanding on my part. I thought the platform was disabled, and that WebKit gardening was unaffected. I was wrong. Now test_expectations has been checked in that makes this disabled for real. I apologize again for the earlier confusion.

[Adam Barth]

Comment on attachment 109338 [details]
Patch

Thanks.  Hopefully this will go smoothly this time.  :)

[WebKit Review Bot]

Comment on attachment 109338 [details]
Patch

Clearing flags on attachment: 109338

Committed r96615: <http://trac.webkit.org/changeset/96615>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.