Bug 69145 – [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zeno Albisser]

[Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents

[Zeno Albisser]

Created attachment 109293 [details]
Patch

[Zeno Albisser]

Comment on attachment 109293 [details]
Patch

it seems i'm not yet really mastering webkit-patch script. - sorry. ;-)

[Chang Shu]

Comment on attachment 109293 [details]
Patch

How come there's no ChangeLog? :) Can you put some comments there why we should choose mouseevents over graphicsscenemouseevents?

[Chang Shu]

Sorry, I didn't realize you cancelled the review. :)

[Zeno Albisser]

Created attachment 109294 [details]
patch for review.

[Chang Shu]

Comment on attachment 109294 [details]
patch for review.

View in context: https://bugs.webkit.org/attachment.cgi?id=109294&action=review

thanks for the change.

> Tools/ChangeLog:6
> +        This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105

i would suggest add more comments for the change.

> Tools/WebKitTestRunner/EventSenderProxy.h:54
> +    QMouseEvent* createMouseEvent(QEvent::Type, const QPoint& pos, const QPoint& screenPos, Qt::MouseButton, Qt::MouseButtons, Qt::KeyboardModifiers);

We don't need a wrapper function any more.

> Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:261
> +    event = new QMouseEvent(type, pos, button, buttons, modifiers);

Simply remove the whole thing and change the calling site.

[Zeno Albisser]

Created attachment 109297 [details]
patch for review - updated according to feedback.

[WebKit Review Bot]

Comment on attachment 109297 [details]
patch for review - updated according to feedback.

Clearing flags on attachment: 109297

Committed r96402: <http://trac.webkit.org/changeset/96402>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.