Bug 69145 - [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
Summary: [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSce...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-30 06:53 PDT by Zeno Albisser
Modified: 2011-09-30 07:53 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.39 KB, patch)
2011-09-30 06:55 PDT, Zeno Albisser
cshu: review-
Details | Formatted Diff | Diff
patch for review. (4.11 KB, patch)
2011-09-30 07:03 PDT, Zeno Albisser
cshu: review-
cshu: commit-queue-
Details | Formatted Diff | Diff
patch for review - updated according to feedback. (4.15 KB, patch)
2011-09-30 07:38 PDT, Zeno Albisser
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2011-09-30 06:53:01 PDT
[Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
Comment 1 Zeno Albisser 2011-09-30 06:55:42 PDT
Created attachment 109293 [details]
Patch
Comment 2 Zeno Albisser 2011-09-30 06:57:36 PDT
Comment on attachment 109293 [details]
Patch

it seems i'm not yet really mastering webkit-patch script. - sorry. ;-)
Comment 3 Chang Shu 2011-09-30 07:01:31 PDT
Comment on attachment 109293 [details]
Patch

How come there's no ChangeLog? :) Can you put some comments there why we should choose mouseevents over graphicsscenemouseevents?
Comment 4 Chang Shu 2011-09-30 07:03:28 PDT
Sorry, I didn't realize you cancelled the review. :)
Comment 5 Zeno Albisser 2011-09-30 07:03:37 PDT
Created attachment 109294 [details]
patch for review.
Comment 6 Chang Shu 2011-09-30 07:15:55 PDT
Comment on attachment 109294 [details]
patch for review.

View in context: https://bugs.webkit.org/attachment.cgi?id=109294&action=review

thanks for the change.

> Tools/ChangeLog:6
> +        This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105

i would suggest add more comments for the change.

> Tools/WebKitTestRunner/EventSenderProxy.h:54
> +    QMouseEvent* createMouseEvent(QEvent::Type, const QPoint& pos, const QPoint& screenPos, Qt::MouseButton, Qt::MouseButtons, Qt::KeyboardModifiers);

We don't need a wrapper function any more.

> Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:261
> +    event = new QMouseEvent(type, pos, button, buttons, modifiers);

Simply remove the whole thing and change the calling site.
Comment 7 Zeno Albisser 2011-09-30 07:38:34 PDT
Created attachment 109297 [details]
patch for review - updated according to feedback.
Comment 8 WebKit Review Bot 2011-09-30 07:53:08 PDT
Comment on attachment 109297 [details]
patch for review - updated according to feedback.

Clearing flags on attachment: 109297

Committed r96402: <http://trac.webkit.org/changeset/96402>
Comment 9 WebKit Review Bot 2011-09-30 07:53:13 PDT
All reviewed patches have been landed.  Closing bug.