Bug 69143 - Replace textInputController.doCommand with eventSender.keyDown in password-echo tests
Summary: Replace textInputController.doCommand with eventSender.keyDown in password-ec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on:
Blocks: 66561
  Show dependency treegraph
 
Reported: 2011-09-30 06:12 PDT by Chang Shu
Modified: 2011-09-30 07:43 PDT (History)
4 users (show)

See Also:


Attachments
patch 1 (2.55 KB, patch)
2011-09-30 06:18 PDT, Chang Shu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2011-09-30 06:12:34 PDT
textInputController.doCommand is not supported very well across the platforms. Replace it with eventSender.keyDown would make the tests pass on more platforms and potentially WK2.
Comment 1 Chang Shu 2011-09-30 06:18:49 PDT
Created attachment 109290 [details]
patch 1
Comment 2 WebKit Review Bot 2011-09-30 07:43:07 PDT
Comment on attachment 109290 [details]
patch 1

Clearing flags on attachment: 109290

Committed r96401: <http://trac.webkit.org/changeset/96401>
Comment 3 WebKit Review Bot 2011-09-30 07:43:12 PDT
All reviewed patches have been landed.  Closing bug.