Bug 69141 – [WK2]Adding C API interface for Web Inspector to handle inspector at client side

• Status: UNCONFIRMED
• Component: WebKit2

[chandra shekar vallala]

As part of https://bugs.webkit.org/show_bug.cgi?id=68235, basic implementation of WebInspector was added. 
- This bug is to implement docking/undocking of web inspector.
- It also attempts to add the interface API for creation & destruction of inspector webview at client side rather than in WebKit.

[chandra shekar vallala]

Initial patch will be uploaded in couple of days.

[Martin Robinson]

I'm concerned with adding default dock/undock behavior. How will you ensure that you are packing the widget into the parent container properly?

[chandra shekar vallala]

(In reply to comment #2)
> I'm concerned with adding default dock/undock behavior. How will you ensure that you are packing the widget into the parent container properly?

The addition of interface API mentioned in the description of bug is to address precisely this issue. Since the client knows the actual widget hierarchy and can pack all the widgets in correct order on detach or attach calls, with this patch I am trying to delegate widget related activity to the client.

[chandra shekar vallala]

Created attachment 110687 [details]
patch for webkit changes

This patch is about the creation of web-inspector window at client side.

[chandra shekar vallala]

(In reply to comment #4)
> Created an attachment (id=110687) [details]
> patch for webkit changes
> 
> This patch is about the creation of web-inspector window at client side.

For creation of inspector window at client side, callbacks have been added to interface files which client can use to open/close/dock/undock inspector window into its current window packing.

[chandra shekar vallala]

Created attachment 110831 [details]
updated patch.

updated the patch with the fix of win-ews build break.

[Carlos Garcia Campos]

Comment on attachment 110831 [details]
updated patch.

This patch is not specific to GTK+ port, it adds new C API so I guess it should be reviewed by apple guys. You should probably rename it too.

[chandra shekar vallala]

andersca/sam,
Can either of you have a look at the attached patch?

[Sam Weinig]

Comment on attachment 110831 [details]
updated patch.

This introduces GTK specific types WebKitWebViewBase, into the implementation layer.

[Martin Robinson]

It's quite possible that this bug is obsolete now...