Bug 69133 - Fix bug in getHostCallReturnValue of DFG JIT on X86
Summary: Fix bug in getHostCallReturnValue of DFG JIT on X86
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-30 00:01 PDT by Yuqiang Xian
Modified: 2011-09-30 13:35 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (2.08 KB, patch)
2011-09-30 00:04 PDT, Yuqiang Xian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuqiang Xian 2011-09-30 00:01:46 PDT
We need to insert the additional argument in the stack slot before return address instead of simply pushing it afterwards. Also getHostCallReturnValue* should be attributed as stdcall to make the stack cleaned up by the callee.
Comment 1 Yuqiang Xian 2011-09-30 00:04:43 PDT
Created attachment 109260 [details]
proposed patch
Comment 2 WebKit Review Bot 2011-09-30 13:35:14 PDT
Comment on attachment 109260 [details]
proposed patch

Clearing flags on attachment: 109260

Committed r96419: <http://trac.webkit.org/changeset/96419>
Comment 3 WebKit Review Bot 2011-09-30 13:35:18 PDT
All reviewed patches have been landed.  Closing bug.