Bug 69130 - LayoutTests: Rewrite fast/dom/HTMLInputElement/input-size-attribute.html
Summary: LayoutTests: Rewrite fast/dom/HTMLInputElement/input-size-attribute.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 23:55 PDT by Antaryami Pandia
Modified: 2011-09-30 09:59 PDT (History)
2 users (show)

See Also:


Attachments
Patch (deleted)
2011-09-29 23:59 PDT, Antaryami Pandia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antaryami Pandia 2011-09-29 23:55:10 PDT
Rewrite fast/dom/HTMLInputElement/input-size-attribute.html with new style. 

older style:-
input.setAttribute("size", "-1");
shouldBe("input.size", "20");

with new style:-
shouldBe("input.setAttribute('size', '-1'); input.size", "20");
Comment 1 Antaryami Pandia 2011-09-29 23:59:55 PDT
Created attachment 109257 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-09-30 08:56:11 PDT
Comment on attachment 109257 [details]
Patch

In the future, please put some rationale in bug and/or ChangeLog. It's not always as easy to guess why a rewrite/refactoring is attempted as it is for this patch.
Comment 3 WebKit Review Bot 2011-09-30 09:59:17 PDT
Comment on attachment 109257 [details]
Patch

Clearing flags on attachment: 109257

Committed r96403: <http://trac.webkit.org/changeset/96403>
Comment 4 WebKit Review Bot 2011-09-30 09:59:21 PDT
All reviewed patches have been landed.  Closing bug.