Bug 69129 - [Qt][WK2] Fix sputnik tests after migrating to refactored Qt5
Summary: [Qt][WK2] Fix sputnik tests after migrating to refactored Qt5
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 69104
  Show dependency tree / graph
 
Reported: 2011-09-29 23:46 PDT by Csaba Osztrogonác
Modified: 2011-10-05 09:45 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-09-29 23:46:26 PDT 
All of them fail with this fail: (missing space after PASS text)


--- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A1.1_T1-expected.txt 
+++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A1.1_T1-actual.txt 
@@ -1,6 +1,6 @@
 S7.2_A1.1_T1
 
"-PASS "
"+PASS"
 
 TEST COMPLETE
Comment 1 Csaba Osztrogonác 2011-09-29 23:53:14 PDT 
There are 5010(all!) failing sputnik tests skipped in qt-wk2/Skipped now.
(And there are 470 sputnik tests run and pass on the WK2 bot.)
Comment 3 Csaba Osztrogonác 2011-09-30 03:52:45 PDT 
javascript code in sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A1.1_T1.html which print PASS message:

...
function printTestPassed(msg)
{
    testPrint('<span><span class="pass">PASS</span> ' + escapeHTML(msg) + '</span>');
}
...

It seems Qt eat somehow the space after the PASS, before the escapeHTML(msg).
Comment 4 Csaba Osztrogonác 2011-10-05 09:45:44 PDT 
Sputnik tests work with newer Qt5, so I unskipped them: http://trac.webkit.org/changeset/96714