Bug 69119 - Remove an unused member in RenderTable::ColumnStruct
Summary: Remove an unused member in RenderTable::ColumnStruct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 18:54 PDT by Julien Chaffraix
Modified: 2011-10-02 12:40 PDT (History)
1 user (show)

See Also:


Attachments
Proposed removal (1.74 KB, patch)
2011-09-29 19:02 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2011-09-29 18:54:41 PDT
m_width was added several years ago and its users were changed so it is not needed.

The code would love a refactoring to extract some of the logic out of RenderTable (the handling columns information would be one). However the code hasn't been seriously challenged so let's just reap the benefit from removing this member.
Comment 1 Julien Chaffraix 2011-09-29 19:02:48 PDT
Created attachment 109237 [details]
Proposed removal
Comment 2 Darin Adler 2011-09-30 10:35:05 PDT
Comment on attachment 109237 [details]
Proposed removal

Seems like ColumnStruct is not much of a struct any more.
Comment 3 Julien Chaffraix 2011-10-02 11:37:35 PDT
Comment on attachment 109237 [details]
Proposed removal

> Seems like ColumnStruct is not much of a struct any more.

Yep, it will need to be removed or the position folded into the structure. No sure which one makes more sense for now.
Comment 4 WebKit Review Bot 2011-10-02 12:40:16 PDT
Comment on attachment 109237 [details]
Proposed removal

Clearing flags on attachment: 109237

Committed r96476: <http://trac.webkit.org/changeset/96476>
Comment 5 WebKit Review Bot 2011-10-02 12:40:19 PDT
All reviewed patches have been landed.  Closing bug.