RESOLVED FIXED 69119
Remove an unused member in RenderTable::ColumnStruct 
https://bugs.webkit.org/show_bug.cgi?id=69119
Summary Remove an unused member in RenderTable::ColumnStruct
Julien Chaffraix
Reported 2011-09-29 18:54:41 PDT
m_width was added several years ago and its users were changed so it is not needed. The code would love a refactoring to extract some of the logic out of RenderTable (the handling columns information would be one). However the code hasn't been seriously challenged so let's just reap the benefit from removing this member.
Attachments
Proposed removal (1.74 KB, patch)
2011-09-29 19:02 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2011-09-29 19:02:48 PDT
Created attachment 109237 [details] Proposed removal
Darin Adler
Comment 2 2011-09-30 10:35:05 PDT
Comment on attachment 109237 [details] Proposed removal Seems like ColumnStruct is not much of a struct any more.
Julien Chaffraix
Comment 3 2011-10-02 11:37:35 PDT
Comment on attachment 109237 [details] Proposed removal > Seems like ColumnStruct is not much of a struct any more. Yep, it will need to be removed or the position folded into the structure. No sure which one makes more sense for now.
WebKit Review Bot
Comment 4 2011-10-02 12:40:16 PDT
Comment on attachment 109237 [details] Proposed removal Clearing flags on attachment: 109237 Committed r96476: <http://trac.webkit.org/changeset/96476>
WebKit Review Bot
Comment 5 2011-10-02 12:40:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.