WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
69117
[chromium] Add WebKit API for sending input events to the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=69117
Summary
[chromium] Add WebKit API for sending input events to the compositor thread
James Robinson
Reported
2011-09-29 18:33:21 PDT
[chromium] Add WebKit API for sending input events to the compositor thread
Attachments
Patch
(34.68 KB, patch)
2011-09-29 18:41 PDT
,
James Robinson
no flags
Details
Formatted Diff
Diff
with a #define to make a 2-sided patch easier
(34.71 KB, patch)
2011-09-29 18:43 PDT
,
James Robinson
no flags
Details
Formatted Diff
Diff
put HAVE_WEBCOMPOSITOR ifdef somewhere useful
(34.79 KB, patch)
2011-09-29 19:05 PDT
,
James Robinson
no flags
Details
Formatted Diff
Diff
Patch
(34.79 KB, patch)
2011-09-29 19:25 PDT
,
James Robinson
fishd
: review+
fishd
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
James Robinson
Comment 1
2011-09-29 18:41:06 PDT
Created
attachment 109234
[details]
Patch
James Robinson
Comment 2
2011-09-29 18:42:20 PDT
With this patch the unit tests all pass and as many layout tests pass as did before with use_threaded_compositing=1. The actual browser hookup of the thread isn't done and will require a chromium change.
James Robinson
Comment 3
2011-09-29 18:43:27 PDT
Created
attachment 109235
[details]
with a #define to make a 2-sided patch easier
WebKit Review Bot
Comment 4
2011-09-29 18:43:33 PDT
Attachment 109234
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/chromium/tests/CCThreadTest.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/chromium/src/WebCompositorImpl.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
James Robinson
Comment 5
2011-09-29 18:44:48 PDT
(In reply to
comment #4
)
>
Attachment 109234
[details]
did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > > Source/WebKit/chromium/tests/CCThreadTest.cpp:32: Alphabetical sorting problem. [build/include_order] [4] > Source/WebKit/chromium/src/WebCompositorImpl.cpp:31: Alphabetical sorting problem. [build/include_order] [4] > Total errors found: 2 in 16 files >
I can't tell what sort order this script is expected - I ran the lines through sort(1) and they look fine to me.
WebKit Review Bot
Comment 6
2011-09-29 18:46:48 PDT
Attachment 109235
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/chromium/tests/CCThreadTest.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/chromium/src/WebCompositorImpl.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
James Robinson
Comment 7
2011-09-29 19:05:22 PDT
Created
attachment 109238
[details]
put HAVE_WEBCOMPOSITOR ifdef somewhere useful
James Robinson
Comment 8
2011-09-29 19:05:36 PDT
Chromium side is here:
http://codereview.chromium.org/8081014/
WebKit Review Bot
Comment 9
2011-09-29 19:07:36 PDT
Attachment 109238
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/chromium/tests/CCThreadTest.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/chromium/src/WebCompositorImpl.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Shawn Singh
Comment 10
2011-09-29 19:09:28 PDT
I think you can at the very least separate the "offending" includes by an extra newline. I think the style check only checks sorting for "clusters of includes", where each cluster is separated by a newline. but, i could be wrong...
James Robinson
Comment 11
2011-09-29 19:25:34 PDT
Created
attachment 109240
[details]
Patch
WebKit Review Bot
Comment 12
2011-09-29 19:27:58 PDT
Attachment 109240
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/chromium/tests/CCThreadTest.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/chromium/src/WebCompositorImpl.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Fisher (:fishd, Google)
Comment 13
2011-09-29 22:56:29 PDT
Comment on
attachment 109240
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=109240&action=review
> Source/WebKit/chromium/public/WebCompositor.h:53 > +#endif // WebCompositor_h
ditto
> Source/WebKit/chromium/public/WebCompositorClient.h:43 > +#endif // WebCompositorClient_h
style-nit: I mistyped this... the style guide suggests putting a comment on the close of the namespace, not on the #endif. i just mixed that up when i was typing this file earlier. the other headers in WebKit/chromium/public/ do it that way.
>> Source/WebKit/chromium/tests/CCThreadTest.cpp:32 >> +#include "CCThreadImpl.h" > > Alphabetical sorting problem. [build/include_order] [4]
Perhaps this is saying that "CC" sorts before "cc"??
James Robinson
Comment 14
2011-09-30 00:04:28 PDT
Committed
r96392
: <
http://trac.webkit.org/changeset/96392
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug