[Qt][WK2] Default directories and paths are missing for LocalStorage, Database and IconDatabase.
Created attachment 109220 [details] Patch
Comment on attachment 109220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109220&action=review > Source/WebKit2/UIProcess/qt/WebContextQt.cpp:41 > + QDir().mkpath(s_dataLocation); What if this fails?
(In reply to comment #2) > (From update of attachment 109220 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109220&action=review > > > Source/WebKit2/UIProcess/qt/WebContextQt.cpp:41 > > + QDir().mkpath(s_dataLocation); > > What if this fails? We could just return empty paths then. Will update the patch on monday.
Created attachment 109641 [details] Patch
(In reply to comment #4) > Created an attachment (id=109641) [details] > Patch The new patch as a fallback to a sensible path if there is no DataLocation from QDesktopServices (it writes into home so the mkdir should work).
Comment on attachment 109641 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109641&action=review > Source/WebKit2/UIProcess/qt/WebContextQt.cpp:85 > + QDir().mkpath(defaultLocalStorageDirectory); Hm, this calls mkpath() every time, which for a given path /foo/bar/baz will stat() /foo, /foo/bar and /foo/bar/baz every time. Maybe that could be avoided :)
Created attachment 109775 [details] Patch
Comment on attachment 109775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109775&action=review > Source/WebKit2/UIProcess/qt/WebContextQt.cpp:78 > + s_defaultDatabaseDirectory = defaultDataLocation() + QLatin1String("Databases"); Are you sure that defaultDataLocation always ends with a / ? It is user configurable right via QDesktopServies
Created attachment 109779 [details] Patch
Comment on attachment 109779 [details] Patch Clearing flags on attachment: 109779 Committed r96702: <http://trac.webkit.org/changeset/96702>
All reviewed patches have been landed. Closing bug.