Bug 69111 – [Qt][WK2] Default directories and paths are missing for LocalStorage, Database and IconDatabase.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Alexis Menard (darktears)]

[Qt][WK2] Default directories and paths are missing for LocalStorage, Database and IconDatabase.

[Alexis Menard (darktears)]

Created attachment 109220 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 109220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109220&action=review

> Source/WebKit2/UIProcess/qt/WebContextQt.cpp:41
> +    QDir().mkpath(s_dataLocation);

What if this fails?

[Alexis Menard (darktears)]

(In reply to comment #2)
> (From update of attachment 109220 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109220&action=review
> 
> > Source/WebKit2/UIProcess/qt/WebContextQt.cpp:41
> > +    QDir().mkpath(s_dataLocation);
> 
> What if this fails?

We could just return empty paths then. Will update the patch on monday.

[Alexis Menard (darktears)]

Created attachment 109641 [details]
Patch

[Alexis Menard (darktears)]

(In reply to comment #4)
> Created an attachment (id=109641) [details]
> Patch

The new patch as a fallback to a sensible path if there is no DataLocation from QDesktopServices (it writes into home so the mkdir should work).

[Simon Hausmann]

Comment on attachment 109641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109641&action=review

> Source/WebKit2/UIProcess/qt/WebContextQt.cpp:85
> +    QDir().mkpath(defaultLocalStorageDirectory);

Hm, this calls mkpath() every time, which for a given path /foo/bar/baz will stat() /foo, /foo/bar and /foo/bar/baz every time.

Maybe that could be avoided :)

[Alexis Menard (darktears)]

Created attachment 109775 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 109775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109775&action=review

> Source/WebKit2/UIProcess/qt/WebContextQt.cpp:78
> +    s_defaultDatabaseDirectory = defaultDataLocation() + QLatin1String("Databases");

Are you sure that defaultDataLocation always ends with a / ? It is user configurable right via QDesktopServies

[Alexis Menard (darktears)]

Created attachment 109779 [details]
Patch

[WebKit Review Bot]

Comment on attachment 109779 [details]
Patch

Clearing flags on attachment: 109779

Committed r96702: <http://trac.webkit.org/changeset/96702>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.