Bug 69109 - Refactor out trivially duplicated code in DFGJITCodeGenerator.
Summary: Refactor out trivially duplicated code in DFGJITCodeGenerator.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-09-29 16:14 PDT by Gavin Barraclough
Modified: 2011-09-29 16:28 PDT (History)
1 user (show)

See Also:

Fix (198.35 KB, patch)
2011-09-29 16:16 PDT, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-09-29 16:14:23 PDT
Some code is trivially redundant between DFGJITCodeGenerator.cpp & DFGJITCodeGenerator32_64.cpp

Basically move a JSVALUE64 specific code into a new DFGJITCodeGenerator64.cpp, leave common code in DFGJITCodeGenerator.cpp, and remove copies from DFGJITCodeGenerator32_64.cpp.

For some function differences are trivial & make more sense to ifdef individually, and some Operand methods make more sense left in DFGJITCodeGenerator.cpp alongside similar constructors.
Comment 1 Gavin Barraclough 2011-09-29 16:16:20 PDT
Created attachment 109214 [details]
Comment 2 Gavin Barraclough 2011-09-29 16:28:12 PDT
Fixed in r96377