Bug 69099 - [Freetype] Some text in Planet GNOME renders in the wrong place
Summary: [Freetype] Some text in Planet GNOME renders in the wrong place
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL: http://planet.gnome.org
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 12:33 PDT by Martin Robinson
Modified: 2011-11-04 12:58 PDT (History)
4 users (show)

See Also:


Attachments
Patch (22.38 KB, patch)
2011-09-29 12:43 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-09-29 12:33:41 PDT
This seems to be an issue with custom fonts which use synthetic oblique rendering.
Comment 1 Martin Robinson 2011-09-29 12:43:26 PDT
Created attachment 109189 [details]
Patch
Comment 2 Dirk Schulze 2011-09-29 12:54:39 PDT
Comment on attachment 109189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109189&action=review

Just one comment to the test.

> LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning.html:26
> +This test verifies that the CTM does not cause text that has
> +a synthetic oblique to render in the wrong part of the page.
> +You should be able to see three separate block characters below
> +and the middle should be rendered in italic.

To be honest, I don't think that it makes sense to use Ahem on the one side, but print the description on the screen as well. Would it be enough to insert it as a HTML comment?
Comment 3 Martin Robinson 2011-09-29 15:22:26 PDT
(In reply to comment #2)

Thanks for the review!
 
> > LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning.html:26
> > +This test verifies that the CTM does not cause text that has
> > +a synthetic oblique to render in the wrong part of the page.
> > +You should be able to see three separate block characters below
> > +and the middle should be rendered in italic.
> 
> To be honest, I don't think that it makes sense to use Ahem on the one side, but print the description on the screen as well. Would it be enough to insert it as a HTML comment?

You're right that it seems a bit weird to use Ahem. Traditionally it's used because it's consistent across platforms.  in this case I used it because it's a custom font that already exists in the tree and doesn't present any licensing issues. If you still think this bit should be an HTML comment, I'm quite happy to do that though.
Comment 4 Martin Robinson 2011-09-29 16:46:39 PDT
Committed r96378: <http://trac.webkit.org/changeset/96378>
Comment 5 Martin Robinson 2011-09-29 17:33:21 PDT
Comment on attachment 109189 [details]
Patch

Landed this one after converting the text to a coment.