Bug 69099 – [Freetype] Some text in Planet GNOME renders in the wrong place

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

This seems to be an issue with custom fonts which use synthetic oblique rendering.

[Martin Robinson]

Created attachment 109189 [details]
Patch

[Dirk Schulze]

Comment on attachment 109189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109189&action=review

Just one comment to the test.

> LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning.html:26
> +This test verifies that the CTM does not cause text that has
> +a synthetic oblique to render in the wrong part of the page.
> +You should be able to see three separate block characters below
> +and the middle should be rendered in italic.

To be honest, I don't think that it makes sense to use Ahem on the one side, but print the description on the screen as well. Would it be enough to insert it as a HTML comment?

[Martin Robinson]

(In reply to comment #2)

Thanks for the review!
 
> > LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning.html:26
> > +This test verifies that the CTM does not cause text that has
> > +a synthetic oblique to render in the wrong part of the page.
> > +You should be able to see three separate block characters below
> > +and the middle should be rendered in italic.
> 
> To be honest, I don't think that it makes sense to use Ahem on the one side, but print the description on the screen as well. Would it be enough to insert it as a HTML comment?

You're right that it seems a bit weird to use Ahem. Traditionally it's used because it's consistent across platforms.  in this case I used it because it's a custom font that already exists in the tree and doesn't present any licensing issues. If you still think this bit should be an HTML comment, I'm quite happy to do that though.

[Martin Robinson]

Committed r96378: <http://trac.webkit.org/changeset/96378>

[Martin Robinson]

Comment on attachment 109189 [details]
Patch

Landed this one after converting the text to a coment.