Bug 69094 - Shrink HTMLAnchorElement on 32-bit.
Summary: Shrink HTMLAnchorElement on 32-bit.
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2011-09-29 10:37 PDT by Andreas Kling
Modified: 2011-09-29 14:01 PDT (History)
2 users (show)

See Also:

Proposed patch (1.21 KB, patch)
2011-09-29 10:40 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Proposed follow-up patch (1.41 KB, patch)
2011-09-29 13:57 PDT, Andreas Kling
darin: review+
darin: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-09-29 10:37:57 PDT
Comment 1 Andreas Kling 2011-09-29 10:40:21 PDT
Created attachment 109174 [details]
Proposed patch
Comment 2 WebKit Review Bot 2011-09-29 13:29:23 PDT
Comment on attachment 109174 [details]
Proposed patch

Clearing flags on attachment: 109174

Committed r96352: <http://trac.webkit.org/changeset/96352>
Comment 3 WebKit Review Bot 2011-09-29 13:29:27 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2011-09-29 13:37:44 PDT
Seems a little strange to use 31 bits for link relations since there are 18 of them total, not 31!
Comment 5 Andreas Kling 2011-09-29 13:43:18 PDT
(In reply to comment #4)
> Seems a little strange to use 31 bits for link relations since there are 18 of them total, not 31!

I thought I was being a little future proof, since we had 31 bits available anyway. I don't mind changing it to 18 bits wide if you prefer.
Comment 6 Darin Adler 2011-09-29 13:45:58 PDT
If I was doing this I would add a comment to the end of the enum mentioning the bitfield below and have the bitfield be exactly the right size.
Comment 7 Andreas Kling 2011-09-29 13:57:16 PDT
Created attachment 109199 [details]
Proposed follow-up patch