RESOLVED FIXED69092
Web Inspector: [chromium] expose inspector protocol version to the embedder. 
https://bugs.webkit.org/show_bug.cgi?id=69092
Summary Web Inspector: [chromium] expose inspector protocol version to the embedder.
Pavel Feldman
Reported 2011-09-29 10:00:48 PDT
Patch to follow.
Attachments
Patch (13.04 KB, patch)
2011-09-29 10:08 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (263.59 KB, patch)
2011-09-30 02:36 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-09-29 10:03:32 PDT
Please find generated file content below: ====================================== #ifndef InspectorProtocolVersion_h #define InspectorProtocolVersion_h #include "PlatformString.h" namespace WebCore { String inspectorProtocolVersion() { return "tip-of-tree"; } bool supportsInspectorProtocolVersion(const String& version) { if (version == "draft-01") return true; if (version == "tip-of-tree") return true; return false; } } #endif // !defined(InspectorProtocolVersion_h) ======================================
Pavel Feldman
Comment 2 2011-09-29 10:08:28 PDT
Created attachment 109171 [details] Patch
Pavel Feldman
Comment 3 2011-09-30 02:36:53 PDT
Created attachment 109270 [details] Patch
Pavel Feldman
Comment 4 2011-09-30 03:27:58 PDT
============================================== #ifndef InspectorProtocolVersion_h #define InspectorProtocolVersion_h #include "PlatformString.h" #include <wtf/Vector.h> namespace WebCore { String inspectorProtocolVersion() { return "0.1"; } int inspectorProtocolVersionMajor() { return 0; } int inspectorProtocolVersionMinor() { return 1; } bool supportsInspectorProtocolVersion(const String& version) { Vector<String> tokens; version.split(".", tokens); if (tokens.size() != 2) return false; bool ok = true; int major = tokens[0].toInt(&ok); if (!ok || major != 0) return false; int minor = tokens[1].toInt(&ok); if (!ok || minor < 1) return false; return true; } } #endif // !defined(InspectorProtocolVersion_h) ==============================================
Pavel Feldman
Comment 5 2011-09-30 03:43:55 PDT
Committed r96398: <http://trac.webkit.org/changeset/96398>
Note You need to log in before you can comment on or make changes to this bug.