Bug 69076 – SVG Mask should take 'color-interpolation' into account to determine the color space of the mask image

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Dirk Schulze]

SVG Mask should take 'color-interpolation' into account to determine the color space of the mask image. This is a change in SVG 1.1 SE. The color space of the mask image gets defined by the computed value of the 'color-interpolation' property. This will switch the default color space from linearRGB to sRGB (a performance improvement for platforms without native support of linearRGB).

[Dirk Schulze]

Created attachment 109198 [details]
Patch

[WebKit Review Bot]

Comment on attachment 109198 [details]
Patch

Attachment 109198 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9900221

New failing tests:
svg/W3C-SVG-1.1/masking-intro-01-f.svg
svg/custom/mask-colorspace.svg
svg/css/circle-in-mask-with-shadow.svg
svg/custom/grayscale-gradient-mask-2.svg

[Dirk Schulze]

The test results must be updated on linux and windows for chromium. I'd do that on landing.

[Simon Fraser (smfr)]

Comment on attachment 109198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109198&action=review

> Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:134
> +void RenderSVGResourceMasker::drawContentIntoMaskImage(MaskerData* maskerData, const ColorSpace colorSpace, const SVGMaskElement* maskElement, RenderObject* object)

ColorSpace doesn't need to be const.

[Dirk Schulze]

Committed r96470: <http://trac.webkit.org/changeset/96470>