Bug 69074 – Refactor IDL attributes about constructor

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Kentaro Hara]

Current situation:

- [CustomConstructFunction] means that there is a custom constructor for JSC.
- [V8CustomConstructor] means that there is a custom constructor for V8.
- [CustomConstructor] exists in CodeGenerator*.pm but is not used in any IDL files. I don't figure out what [CustomConstructor] means. As far as I see CodeGeneratorV8.pm, [CustomConstructor] works equivalent to [V8CustomConstructor]. On the other hand, as far as I see CodeGeneratorJS.pm, [CustomConstructor] works equivalent to [OmitConstructor]. Anyway, no IDL files are using [CustomConstructor].
- For almost all IDL files, [CustomConstructFunction] and [V8CustomConstructor] are used at the same time.
- ObjC, CPP and GObject bindings do not support custom constructors.

I am planning to refactor the above situation as follows:

- Remove [CustomConstructFunction] and add [JSCustomConstructor].
- [JSCustomConstructor] means that there is a custom constructor for JSC.
- [V8CustomConstructor] means that there is a custom constructor for V8.
- [CustomConstructor] means that there is a custom constructor for both JSC and V8.

[Kentaro Hara]

Created attachment 109137 [details]
Patch

[Hajime Morrita]

The change looks trivial and making sense. 
- A simple renaming from [CustomConstructFunction] to [JSCustomConstructor].
- Addition of [CustomConstructor] for a shorthand for JSCustomConstructor + V8CustomConstructor.

I'd like to r+ this later but a quick glance from an expert would be appreciated.

[Dominic Cooney]

Comment on attachment 109137 [details]
Patch

Looks like good clean-up. Possible to split into a few patches but makes sense as-is. No change to test IDL files/output?

[Kentaro Hara]

Created attachment 109912 [details]
rebased patch for commit

[Kentaro Hara]

Created attachment 109913 [details]
rebased patch for commit

[Kentaro Hara]

(In reply to comment #3)
> (From update of attachment 109137 [details])
> Looks like good clean-up. Possible to split into a few patches but makes sense as-is. No change to test IDL files/output?

Dominic: No change to test IDL files, since they have an [Constructor] IDL and thus do not have an IDL for custom constructor.

[WebKit Review Bot]

Comment on attachment 109913 [details]
rebased patch for commit

Clearing flags on attachment: 109913

Committed r96788: <http://trac.webkit.org/changeset/96788>