After http://trac.webkit.org/changeset/95897/, the following two tests started failing: fast/frames/flattening/frameset-flattening-advanced.html fast/frames/flattening/frameset-flattening-subframesets.html It was also failing on GTK but it was rebaselined in http://trac.webkit.org/changeset/96080/.
All regressions are P1.
Note that the tests are failing on Mac and GTK: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r96301%20(33501)/results.html http://build.webkit.org/results/GTK%20Linux%2032-bit%20Debug/r96077%20(17487)/results.html
Any update on this bug? The tests are still failing on the waterfall.
These tests are skipped on Chromium, that's why I didn't notice that their output changing. Kenneth, do you have any ideas why a change in ScrollView to correctly propagate resizing (http://trac.webkit.org/changeset/95897/) would affect these tests?
Created attachment 109649 [details] frameset-flattening-advanced-actual.png
Attached is the pixel output on Snow Leopard (compare with http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.png). However, I'm not seeing those differences when displaying the test directly in Safari (though frameset flatenning is not enabled there).
(In reply to comment #4) > These tests are skipped on Chromium, that's why I didn't notice that their output changing. > > Kenneth, do you have any ideas why a change in ScrollView to correctly propagate resizing (http://trac.webkit.org/changeset/95897/) would affect these tests? Resizing iframes etc would cause layout of parents, do you think that is what is happening here?
Huh, these tests are also failing on WebKit2: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r97220%20(15390)/results.html fast/frames/flattening/frameset-flattening-subframesets.html skipped in WK2 due to the bug 60648.
Committed failing expectation in http://trac.webkit.org/changeset/97228 for now.