Bug 69069 - REGRESSION(95897): fast/frames/flattening/frameset-flattening-advanced.html and frameset-flattening-subframesets.html fail
Summary: REGRESSION(95897): fast/frames/flattening/frameset-flattening-advanced.html a...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 01:08 PDT by Ryosuke Niwa
Modified: 2011-10-11 21:36 PDT (History)
6 users (show)

See Also:


Attachments
frameset-flattening-advanced-actual.png (36.39 KB, image/png)
2011-10-04 10:57 PDT, Mihai Parparita
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-09-29 01:08:22 PDT
After http://trac.webkit.org/changeset/95897/, the following two tests started failing:
fast/frames/flattening/frameset-flattening-advanced.html
fast/frames/flattening/frameset-flattening-subframesets.html

It was also failing on GTK but it was rebaselined in http://trac.webkit.org/changeset/96080/.
Comment 1 Ryosuke Niwa 2011-09-29 01:08:40 PDT
All regressions are P1.
Comment 3 Ryosuke Niwa 2011-10-04 10:09:23 PDT
Any update on this bug? The tests are still failing on the waterfall.
Comment 4 Mihai Parparita 2011-10-04 10:35:17 PDT
These tests are skipped on Chromium, that's why I didn't notice that their output changing.

Kenneth, do you have any ideas why a change in ScrollView to correctly propagate resizing (http://trac.webkit.org/changeset/95897/) would affect these tests?
Comment 5 Mihai Parparita 2011-10-04 10:57:16 PDT
Created attachment 109649 [details]
frameset-flattening-advanced-actual.png
Comment 6 Mihai Parparita 2011-10-04 11:02:38 PDT
Attached is the pixel output on Snow Leopard (compare with http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.png). However, I'm not seeing those differences when displaying the test directly in Safari (though frameset flatenning is not enabled there).
Comment 7 Kenneth Rohde Christiansen 2011-10-05 03:58:47 PDT
(In reply to comment #4)
> These tests are skipped on Chromium, that's why I didn't notice that their output changing.
> 
> Kenneth, do you have any ideas why a change in ScrollView to correctly propagate resizing (http://trac.webkit.org/changeset/95897/) would affect these tests?

Resizing iframes etc would cause layout of parents, do you think that is what is happening here?
Comment 8 Ryosuke Niwa 2011-10-11 21:31:03 PDT
Huh, these tests are also failing on WebKit2:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r97220%20(15390)/results.html

fast/frames/flattening/frameset-flattening-subframesets.html skipped in WK2 due to the bug 60648.
Comment 9 Ryosuke Niwa 2011-10-11 21:36:12 PDT
Committed failing expectation in http://trac.webkit.org/changeset/97228 for now.