RESOLVED WONTFIX 69065
HTML5 forms having single input box & disabled submit button gets submitted implicitly on enter
https://bugs.webkit.org/show_bug.cgi?id=69065
Summary HTML5 forms having single input box & disabled submit button gets submitted i...
Kaustubh Atrawalkar
Reported 2011-09-28 23:58:15 PDT
Created attachment 109127 [details] Test Case A HTML5 form having only one input box and disabled (but visible) Submit button do get submitted on enter key press. Rationale - Safari (WebKit) - Submits form MSIE - Submits form Firefox - Do not submit Opera - Do not submit
Attachments
Test Case (122 bytes, text/html)
2011-09-28 23:58 PDT, Kaustubh Atrawalkar
no flags
Patch (4.33 KB, patch)
2011-09-29 04:32 PDT, Kaustubh Atrawalkar
no flags
Patch (5.67 KB, patch)
2011-09-29 04:38 PDT, Kaustubh Atrawalkar
ap: review-
ap: commit-queue-
Alexey Proskuryakov
Comment 1 2011-09-29 00:06:19 PDT
> Safari (WebKit) - Submits form > MSIE - Submits form Sounds like WONTFIX then.
Kaustubh Atrawalkar
Comment 2 2011-09-29 00:16:14 PDT
But this seems to be followed up approach. As per the specs there is clear guideline mentioned - http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#implicit-submission "Note:Consequently, if the default button is disabled, the form is not submitted when such an implicit submission mechanism is used. (A button has no activation behavior when disabled.)"
Kaustubh Atrawalkar
Comment 3 2011-09-29 04:32:56 PDT
Created attachment 109151 [details] Patch Patch for disabling submission for form having single input box & disabled submit button.
Kaustubh Atrawalkar
Comment 4 2011-09-29 04:38:54 PDT
Created attachment 109152 [details] Patch Missed updated test case results. Updated.
Alexey Proskuryakov
Comment 5 2011-09-29 09:02:49 PDT
Comment on attachment 109152 [details] Patch We cannot flip behavior back and fourth every time a contributor disagrees with the previous choice. If you svn blame test line that says "match IE, not FF", you'll find that it was investigated very recently, and we went with IE behavior intentionally. If we take this patch, what should stop us from taking a patch that reverts the behavior to IE compatible a few months later?
Kaustubh Atrawalkar
Comment 6 2011-09-29 20:59:05 PDT
(In reply to comment #5) > (From update of attachment 109152 [details]) > We cannot flip behavior back and fourth every time a contributor disagrees with the previous choice. If you svn blame test line that says "match IE, not FF", you'll find that it was investigated very recently, and we went with IE behavior intentionally. > I don't want to make it flip and change the behaviour. It was just when I was working on forms I happened to see this behaviour. I agree that this change was made intentionally to match IE and without knowing that It was not worth to change it again. > If we take this patch, what should stop us from taking a patch that reverts the behavior to IE compatible a few months later? I think this would be WONTFIX then.
Note You need to log in before you can comment on or make changes to this bug.