Bug 69059 - DFG checkArgumentTypes fails to check boolean predictions
Summary: DFG checkArgumentTypes fails to check boolean predictions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-28 22:42 PDT by Filip Pizlo
Modified: 2011-09-29 00:36 PDT (History)
2 users (show)

See Also:

Attachments
the patch (2.60 KB, patch)
2011-09-28 23:17 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch, with test (6.83 KB, patch)
2011-09-28 23:58 PDT, Filip Pizlo 		barraclough: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-09-28 22:42:28 PDT 
This is causing really bizarre failures: https://bugs.webkit.org/show_bug.cgi?id=69038
Comment 1 Oliver Hunt 2011-09-28 22:44:27 PDT 
Craziness
Comment 2 Filip Pizlo 2011-09-28 23:17:23 PDT 
Created attachment 109123 [details]
the patch
Comment 3 Filip Pizlo 2011-09-28 23:36:07 PDT 
All tests pass.
Comment 4 Gavin Barraclough 2011-09-28 23:39:39 PDT 
The patch looks okay, but wouldn't it be possible to write a test for this?
Say, call a function many times with a boolean, then throw an object at it?
Probably should be r- for lack of layout test.
Comment 5 Filip Pizlo 2011-09-28 23:44:41 PDT 
(In reply to comment #4)
> The patch looks okay, but wouldn't it be possible to write a test for this?
> Say, call a function many times with a boolean, then throw an object at it?
> Probably should be r- for lack of layout test.

This already has test coverage; it makes fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml fail.

But sure, it would be easy to write a test.  I'll do it after getting some sleep.
Comment 6 Filip Pizlo 2011-09-28 23:58:46 PDT 
Created attachment 109128 [details]
the patch, with test
Comment 7 Gavin Barraclough 2011-09-29 00:03:59 PDT 
Comment on attachment 109128 [details]
the patch, with test

Yay!
Comment 8 Filip Pizlo 2011-09-29 00:36:01 PDT 
Landed in r96306.