Bug 69046 – DFG JIT Operations on 32_64 should use stdcall calling convention.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

All calls out are expecting stdcall conventions, but the default on OS X are cdecl.

[Gavin Barraclough]

Created attachment 109106 [details]
Fix

[WebKit Review Bot]

Attachment 109106 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Last 3072 characters of output:
iptCore/dfg/DFGOperations.h:88:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:278:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:278:  The parameter name "returnAddress" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:301:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:301:  The parameter name "returnAddress" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:321:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:321:  The parameter name "returnAddress" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:341:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:341:  The parameter name "returnAddress" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:405:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:405:  The parameter name "returnAddress" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:428:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:428:  The parameter name "returnAddress" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:451:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:451:  The parameter name "returnAddress" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:474:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:474:  The parameter name "returnAddress" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:658:  The parameter name "returnAddress" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:671:  The parameter name "returnAddress" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 33 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 109106 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=109106&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:59
> +// Defined on X86 platforms if stdcall is not the standard!
> +#define STDCALL_NOT_STANDARD __attribute__ ((stdcall))

How about we replace the second standard with default.  This should probably be in Compiler.h.

> Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h:1319
> +#if !PLATFORM(MAC)

Please give this #define a more clear explanation.

[Gavin Barraclough]

Fixed in r96286.

[Ryosuke Niwa]

It seems like this patch broke Qt and EFL builds:
http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/33358/steps/compile-webkit/logs/stdio
http://build.webkit.org/builders/EFL%20Linux%20Release%20%28Build%29/builds/22514/steps/compile-webkit/logs/stdio

[Ryosuke Niwa]

Also Windows and Mac:
http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/21506/steps/compile-webkit/logs/stdio
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Build%29/builds/34281/steps/compile-webkit/logs/stdio

[Ryosuke Niwa]

Build fix attempted in http://trac.webkit.org/changeset/96288.

But now Leopard is broken although this failure seems much more reasonable:
http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Build%29/builds/39971/steps/compile-webkit/logs/stdio