Bug 69033 - Complex spaces with synthetic bold are too wide
Summary: Complex spaces with synthetic bold are too wide
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-09-28 15:07 PDT by Ned Holbrook
Modified: 2011-09-30 10:05 PDT (History)
3 users (show)

See Also:

Proposed changes. (94.88 KB, patch)
2011-09-28 16:54 PDT, Ned Holbrook
mitz: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ned Holbrook 2011-09-28 15:07:48 PDT
ComplexTextController doubly applies space characters’ synthetic bold offset. This is because adjustGlyphsAndAdvances() calls fontData->spaceWidth() [which comes from SimpleFontData::platformWidthForGlyph() and thus includes m_syntheticBoldOffset] but then proceeds to unconditionally adds fontData->syntheticBoldOffset().
Comment 1 Ned Holbrook 2011-09-28 15:08:58 PDT
UniscribeController::shapeAndPlaceItem() does the same thing, so I’ll apply a blind fix to it at the same time.
Comment 2 Ned Holbrook 2011-09-28 16:54:34 PDT
Created attachment 109092 [details]
Proposed changes.
Comment 3 Ned Holbrook 2011-09-28 17:20:05 PDT
I'm not sure why my patch failed the style queue since it succeeds on my machine with r96265.
Comment 4 WebKit Review Bot 2011-09-28 17:49:04 PDT
Comment on attachment 109092 [details]
Proposed changes.

Attachment 109092 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9884668

New failing tests:
Comment 5 mitz 2011-09-30 10:05:56 PDT
Landed in <http://trac.webkit.org/r96404>.