WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
69025
Web Inspector: Make search-in-resource test simpler.
https://bugs.webkit.org/show_bug.cgi?id=69025
Summary
Web Inspector: Make search-in-resource test simpler.
Vsevolod Vlasov
Reported
2011-09-28 13:37:14 PDT
Make search-in-resource test simpler.
Attachments
Patch
(10.15 KB, patch)
2011-09-28 13:52 PDT
,
Vsevolod Vlasov
no flags
Details
Formatted Diff
Diff
Patch
(12.08 KB, patch)
2011-09-29 05:40 PDT
,
Vsevolod Vlasov
pfeldman
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1
2011-09-28 13:52:49 PDT
Created
attachment 109069
[details]
Patch
Pavel Feldman
Comment 2
2011-09-28 22:24:38 PDT
Comment on
attachment 109069
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=109069&action=review
> LayoutTests/http/tests/inspector/search/search-test.js:41 > + setTimeout(InspectorTest._runAfterResourcesAreCreated.bind(InspectorTest, resourceURLs, callback), 0);
setTimeout is a source of flake. You should sniff for calls you expect instead.
> Source/WebCore/inspector/InspectorPageAgent.cpp:489 > + *object = InspectorArray::create();
It is not an object. Rename this to "array" or "results"?
> Source/WebCore/inspector/front-end/NetworkManager.js:70 > + searchInResource: function(resource, query, callback)
This change blurs the distinction between Requests vs Resources. We should not talk to PageAgent from within network manager if at all possible.
Vsevolod Vlasov
Comment 3
2011-09-29 05:40:23 PDT
Created
attachment 109155
[details]
Patch
WebKit Review Bot
Comment 4
2011-09-29 05:43:48 PDT
Attachment 109155
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1 Source/WebCore/inspector/InspectorPageAgent.cpp:487: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorPageAgent.cpp:525: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Vsevolod Vlasov
Comment 5
2011-09-29 05:58:37 PDT
Committed
r96323
: <
http://trac.webkit.org/changeset/96323
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug