Bug 68997 – Web Inspector: update call frame location when source mapping is changed.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: update call frame location when source mapping is changed.

Currently we use fake "debugger-paused" event hack to update execution line and call stack placards when source mapping is changed.
- add PresentationCallFrame.createPlacard method to create "live" placards that are updated on source mapping changes. This works like DebuggerPresentationModel.linkifyLocation.
- fire execution-line-changed event when selected call frame or source mapping is changed.

[Pavel Podivilov]

Created attachment 109009 [details]
Patch

[Pavel Feldman]

Comment on attachment 109009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109009&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:378
> +            this._executionRawSourceCode.removeEventListener(WebInspector.RawSourceCode.Events.SourceMappingUpdated, this._dispatchExecutionLineChanged, this);

I don't think the concept of the executionRawSourceCode should exist. Execution line for us is the line of the call frame, the one from the UI.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:-445
> -    get isInternalScript()

You should mention this change in the ChangeLog

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:509
> +        this._rawSourceCode.addEventListener(WebInspector.RawSourceCode.Events.SourceMappingUpdated, updatePlacard, this);

Why aren't we using linkifyLocation here?

[Pavel Podivilov]

(In reply to comment #2)
> (From update of attachment 109009 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109009&action=review
> 
> > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:378
> > +            this._executionRawSourceCode.removeEventListener(WebInspector.RawSourceCode.Events.SourceMappingUpdated, this._dispatchExecutionLineChanged, this);
> 
> I don't think the concept of the executionRawSourceCode should exist. Execution line for us is the line of the call frame, the one from the UI.

Done.

> 
> > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:-445
> > -    get isInternalScript()
> 
> You should mention this change in the ChangeLog

Done.

> 
> > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:509
> > +        this._rawSourceCode.addEventListener(WebInspector.RawSourceCode.Events.SourceMappingUpdated, updatePlacard, this);
> 
> Why aren't we using linkifyLocation here?

linkifyLocation creates anchors, not placards. How can we use it here?

[Pavel Podivilov]

Created attachment 109131 [details]
Patch

[Pavel Podivilov]

Committed r96588: <http://trac.webkit.org/changeset/96588>