Bug 68992 - [GTK] missing WebKit2 support in run-gtk-tests
Summary: [GTK] missing WebKit2 support in run-gtk-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-28 03:38 PDT by Philippe Normand
Modified: 2011-09-28 04:25 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch (1.47 KB, patch)
2011-09-28 03:40 PDT, Philippe Normand
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-09-28 03:38:46 PDT
The script assumes all tests are in Programs/unittests but the webkit2 tests and inside a webkit2 directory there.
Comment 1 Philippe Normand 2011-09-28 03:40:24 PDT
Created attachment 108997 [details]
proposed patch
Comment 2 Carlos Garcia Campos 2011-09-28 03:45:28 PDT
Comment on attachment 108997 [details]
proposed patch

Looks good to me. Now we should make sure all tests are named test*. Maybe we should move webkit1 test into a webkit directory so that we have Programs/unittests/webkit/* and Programs/unittests/webkit2/*
Comment 3 Philippe Normand 2011-09-28 04:02:55 PDT
(In reply to comment #2)
> (From update of attachment 108997 [details])
> Looks good to me. Now we should make sure all tests are named test*. Maybe we should move webkit1 test into a webkit directory so that we have Programs/unittests/webkit/* and Programs/unittests/webkit2/*

Yes that would be better indeed. I think it could be done in a follow-up patch, I wanted to keep this one minimal to get the API tests back up on the bots.
Comment 4 Carlos Garcia Campos 2011-09-28 04:16:45 PDT
Yes, I meant in a following patch indeed.
Comment 5 Philippe Normand 2011-09-28 04:25:15 PDT
Committed r96214: <http://trac.webkit.org/changeset/96214>