Bug 68984 - "ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&"
Summary: "ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&"
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-09-28 01:36 PDT by Kentaro Hara
Modified: 2011-10-12 01:36 PDT (History)
6 users (show)

See Also:

Patch (3.63 KB, patch)
2011-09-28 01:38 PDT, Kentaro Hara
darin: review+
Details | Formatted Diff | Diff
rebased patch for commit (3.73 KB, patch)
2011-09-28 16:56 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-09-28 01:36:25 PDT
Just a follow-up fix for the bug 68345.
Comment 1 Kentaro Hara 2011-09-28 01:38:47 PDT
Created attachment 108985 [details]
Comment 2 Darin Adler 2011-09-28 09:31:45 PDT
Comment on attachment 108985 [details]

Next time, please say “why” in the change log, not just what you are changing.
Comment 3 Kentaro Hara 2011-09-28 16:56:13 PDT
Created attachment 109093 [details]
rebased patch for commit
Comment 4 WebKit Review Bot 2011-09-28 17:00:32 PDT
Comment on attachment 109093 [details]
rebased patch for commit

Rejecting attachment 109093 [details] from commit-queue.

haraken@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 WebKit Review Bot 2011-09-28 23:06:24 PDT
Comment on attachment 109093 [details]
rebased patch for commit

Clearing flags on attachment: 109093

Committed r96301: <http://trac.webkit.org/changeset/96301>