Bug 68968 – Only resolve direction aware properties when properties are direction aware.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Luke Macpherson]

Only resolve direction aware properties when properties are direction aware.

[Luke Macpherson]

Created attachment 108957 [details]
Patch

[Eric Seidel (no email)]

I'm not entirely sure what this does.  How will we know when we get this wrong?  How do we know that we are using the correct list of "directionally aware" properties?

[Luke Macpherson]

(In reply to comment #2)
> I'm not entirely sure what this does.  How will we know when we get this wrong?  How do we know that we are using the correct list of "directionally aware" properties?

At the moment we try to resolve all property id's which is unnecessary. We can't really miss any because all properties are listed in the switch in applyProperty().

[Eric Seidel (no email)]

Comment on attachment 108957 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108957&action=review

This seems reasonable to make directional properties slower at the cost of making all other properties faster.

> Source/WebCore/css/CSSStyleSelector.cpp:3635
> +        return applyProperty(CSSProperty::resolveDirectionAwareProperty(id, m_style->direction(), m_style->writingMode()), value);

Are we sure we're calling this with the right arguments?

[Luke Macpherson]

Comment on attachment 108957 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108957&action=review

>> Source/WebCore/css/CSSStyleSelector.cpp:3635
>> +        return applyProperty(CSSProperty::resolveDirectionAwareProperty(id, m_style->direction(), m_style->writingMode()), value);
> 
> Are we sure we're calling this with the right arguments?

Looks ok to me - resolveDirectionAwareProperty just translates the direction aware property id to the appropriate property id for the current context.
I might add an ASSERT_NOT_REACHED() to the default case of that function, just to ensure we can't infinite loop here.

[Luke Macpherson]

Created attachment 108971 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 108971 [details]
Patch

This is much clearer now, thank you.

[WebKit Review Bot]

Comment on attachment 108971 [details]
Patch

Rejecting attachment 108971 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
sed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/css/CSSStyleSelector.cpp
Hunk #1 FAILED at 2360.
Hunk #2 succeeded at 3596 (offset -2 lines).
Hunk #3 succeeded at 3632 (offset -2 lines).
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/css/CSSStyleSelector.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/9881821

[Luke Macpherson]

Created attachment 109090 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 109090 [details]
Patch for landing

Clearing flags on attachment: 109090

Committed r96281: <http://trac.webkit.org/changeset/96281>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.