Bug 68967 - [chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested
Summary: [chromium] Only initiate the beginFrameAndCommit sequence if a commit has bee...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-27 20:31 PDT by James Robinson
Modified: 2011-09-27 21:02 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.88 KB, patch)
2011-09-27 20:32 PDT, James Robinson
no flags Details | Formatted Diff | Diff
Patch (1.88 KB, patch)
2011-09-27 20:45 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2011-09-27 20:31:24 PDT
[chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested
Comment 1 James Robinson 2011-09-27 20:32:27 PDT
Created attachment 108954 [details]
Patch
Comment 2 James Robinson 2011-09-27 20:33:17 PDT
With this patch the CCLayerTreeHost* tests pass with use_threaded_compositing=1 in debug.
Comment 3 James Robinson 2011-09-27 20:44:16 PDT
Comment on attachment 108954 [details]
Patch

Gah this is clearly wrong - m_commitRequested can only be accessed from the main thread.  Will update...
Comment 4 Kenneth Russell 2011-09-27 20:45:22 PDT
Yes, seemed that you should be looking at the commitRequested argument.
Comment 5 James Robinson 2011-09-27 20:45:47 PDT
Created attachment 108955 [details]
Patch
Comment 6 Kenneth Russell 2011-09-27 20:46:35 PDT
Comment on attachment 108955 [details]
Patch

That looks better. r=me
Comment 7 James Robinson 2011-09-27 20:49:40 PDT
Right you are, Ken.  Thanks.
Comment 8 WebKit Review Bot 2011-09-27 21:02:30 PDT
Comment on attachment 108955 [details]
Patch

Clearing flags on attachment: 108955

Committed r96185: <http://trac.webkit.org/changeset/96185>
Comment 9 WebKit Review Bot 2011-09-27 21:02:34 PDT
All reviewed patches have been landed.  Closing bug.