WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
68966
[chromium mac] Remove AccessibilityObjectWrapper references from gyp project files
https://bugs.webkit.org/show_bug.cgi?id=68966
Summary
[chromium mac] Remove AccessibilityObjectWrapper references from gyp project ...
noel gordon
Reported
2011-09-27 19:58:26 PDT
AccessibilityObjectWrapper.{h,mm} were renamed in
r95448
8 days ago.
Attachments
Patch
(1.59 KB, patch)
2011-09-27 20:05 PDT
,
noel gordon
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
noel gordon
Comment 1
2011-09-27 20:05:24 PDT
Created
attachment 108951
[details]
Patch
noel gordon
Comment 2
2011-09-29 18:24:16 PDT
Dan or Adam, could one of you review please?
Adam Barth
Comment 3
2011-09-29 20:05:49 PDT
Comment on
attachment 108951
[details]
Patch dpranke has the identical patch, btw. It's a race!
noel gordon
Comment 4
2011-09-29 21:44:04 PDT
who's winning? were do place bets?
WebKit Review Bot
Comment 5
2011-09-29 21:48:50 PDT
Comment on
attachment 108951
[details]
Patch Rejecting
attachment 108951
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: '/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/WebCore.gypi Hunk #1 FAILED at 1700. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/WebCore.gypi.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output:
http://queues.webkit.org/results/9889589
Adam Barth
Comment 6
2011-09-29 21:52:38 PDT
I think that means Dirk's patch won the pony race.
noel gordon
Comment 7
2011-09-29 22:28:21 PDT
I'll send Dirk a pony.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug